app/setxkbmap, app/xkbcomp, app/xkbevd and data/xkbdata all depend on knowing
the correct location of XKB data (which should now be /usr/share/X11/xkb by
default). Also the location of xkbcomp needs to be consistent, as some programs
look for it in .../xkb/xkbcomp, which is no longer correct. In the long run this
simply needs to be $(bindir), but should be configurable for e.g. distributions
that might need to release updates compatible with existing layouts.
This patch corrects the default locations in setxkbmap, xkbcomp and xkbevd; adds
a configure option to xkbdata; and corrects xkbdata default install location
from $(libdir) to $(datadir).
The patch didn't get attached it seems. What's up?
(In reply to comment #1)
> The patch didn't get attached it seems. What's up?
I fell asleep :) Attaching in a moment.
Created attachment 3294 [details] [review]
xkb locations fix
Created attachment 3395 [details] [review]
Better fix putting xkb data dir, bin dir and compiled output dir in kbproto.pc
This puts all the config in one place, and allows external packages to pick up
the XKB data location via pkg-config. Also amends xkbdata, xkbcomp, setxkbmap,
xkbevd and xorg configure.ac to use pkg-config to look up XKB paths. Paths can
be overridden by configure flags on each package, this probably isn't necessary
but since the server was allowing xkbdatadir and xkmoutputdir to be set anyway,
seems more consistent.
Added patch keyword
I think the entire part of this patch that applies to xkbdata should be ignored,
and any necessary changes should be added to xkeyboard-config instead.
i won't be doing this for 7.2. will be done async in xk-c, then updated for 7.3.
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Move to 7.3 tracker.
While this is a fine improvement to be done, it doesn't seem to be blocker-class.
Closing this bug, afaict this is now possible through various configure options.
xkeyboard-config has --with-xkb-base
xserver has --with-xkb-bin-directory, --with-xkb-path, --with-xkb-output
xkbcomp has --with-xkb-config-root