| Summary: | [SNB 9.1 Bisected]Ogles2conform GL2ExtensionTests/depth_texture_cube_map/depth_texture_cube_map.test fail | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Paul Berry <stereotype441> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | chadversary, idr, stereotype441, xunx.fang |
| Version: | 9.1 | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | output | ||
|
Description
lu hua
2013-05-16 06:53:53 UTC
Chad and Paul, Can one of you either fix this or revert in the next 24 hours? Thanks. (In reply to comment #1) > Chad and Paul, > > Can one of you either fix this or revert in the next 24 hours? Thanks. I've confirmed that I can reproduce the bug on Sandy Bridge. I'll investigate and update the bug as soon as I know more. I suspect that this patch depends on one the patches in my Haswell HiZ series (d5f7aebac..e4484a030) on master, none of which were cherry-picked. Found the problem. When intel_finalize_mipmap_tree() calls intel_miptree_copy_teximage() to reassemble a depth miptree that has been broken apart into pieces (to deal with misalignment of levels/layers within the miptree), it just copies the depth data, not the HiZ data. This is reasonable, since the alignment restrictions of HiZ are a large part of the reason why the miptree had to be broken apart in the first place. However, in order for the depth copy to be sufficient, we need to do a depth resolve first, to make sure any deferred depth writes that are in the HiZ buffer get performed. Currently we don't have any code to do the necessary depth resolve. The reason the bug shows up on Sandy Bridge but not Ivy Bridge is that Ivy Bridge has a different QPitch formula (as a result of supporting a slightly larger maximum texture size), and coincidentally for the buffer size used in the test, only Sandy Bridge's QPitch formula results in misaligned layers in the texture. I have a small patch that fixes the bug (http://lists.freedesktop.org/archives/mesa-dev/2013-May/039449.html). It's already been reviewed by Chad. I'll do some more testing this afternoon, and unless I uncover a problem with it, I'll commit it to the master branch and cherry-pick it back to 9.1 by the end of the day. Fixed by commit cbe0e50247c909a7d34f71d9a1a4852b6c3af472 Author: Paul Berry <stereotype441@gmail.com> Date: Thu May 16 14:12:15 2013 -0700 intel: Do a depth resolve before copying images between miptrees. When intel_finalize_mipmap_tree() calls intel_miptree_copy_teximage() to reassemble a depth miptree that has been broken apart into pieces (to deal with misalignment of levels/layers within the miptree), it just copies the depth data, not the HiZ data. This is reasonable, since the alignment restrictions of HiZ are a large part of the reason why the miptree had to be broken apart in the first place. However, in order for the depth copy to be sufficient, we need to do a depth resolve first, to make sure any deferred depth writes that are in the HiZ buffer get performed. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=64662 and https://bugs.freedesktop.org/show_bug.cgi?id=64659. NOTE: This is a candidate for stable release branches. Reviewed-by: Chad Versace <chad.versace@linux.intel.com> (cherry picked from commit 46ea8041074df79561f9771e2ecf198f2cbd088f) Verified.Fixed by commit cbe0e50247c909a7d34f71d9a1a4852b6c3af472. commit cbe0e50247c909a7d34f71d9a1a4852b6c3af472 Author: Paul Berry <stereotype441@gmail.com> Date: Thu May 16 14:12:15 2013 -0700 intel: Do a depth resolve before copying images between miptrees. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.