Bug 64810

Does setting the environment variable EGL_DRIVER=egl_dri2 help?

yes, effectively setting this environment variable works fine it seems.

only thing is weston give this warning, not sure if important

EGL_EXT_buffer_age not supported. Performance could be affected

I think the problem is that egl_gallium.so links both radeonsi and r600g, which have some conflicting symbols.

BTW, if you don't need OpenVG support, building Mesa without --enable-gallium-egl (or with --disable-gallium-egl) might avoid this problem.

well im using gentoo so /etc/env.d/00egl did the trick to make it global, so its working that way it seems[kwin_gles works fine now].

should i close the report? 

many thanks for your help

btw i hit this other bug https://bugzilla.kernel.org/show_bug.cgi?id=58621 maybe you know someone who could check it out or give me some advice's in how to debug it further?

(In reply to comment #5)
> should i close the report? 

No. It's just a workaround, not a fix.

*** Bug 68273 has been marked as a duplicate of this bug. ***

(In reply to comment #3)
> I think the problem is that egl_gallium.so links both radeonsi and r600g,
> which have some conflicting symbols.

Maybe this patch helps:
https://github.com/jobermayr/mesa/commit/27db605

hello there, i'm having the same issue and i recompiled mesa with debugging symbols.
i'm using mesa-9.2.0_rc1 on gentoo.
i attached gdb and i found that the issue is at src/gallium/drivers/r600/r600_query.c:743.

735     void r600_init_query_functions(struct r600_context *rctx)
736     {
737             rctx->context.create_query = r600_create_query;
738             rctx->context.destroy_query = r600_destroy_query;
739             rctx->context.begin_query = r600_begin_query;
740             rctx->context.end_query = r600_end_query;
741             rctx->context.get_query_result = r600_get_query_result;
742
743             if (rctx->screen->info.r600_num_backends > 0)

breaking gdb on line 743 i got this: http://pastebin.com/A4JANB5F

as you can see rctx->screen is null ( 0x0 ), please, can you fix that?

i hope this helps.

(In reply to comment #3)
> I think the problem is that egl_gallium.so links both radeonsi and r600g,
> which have some conflicting symbols.

you're right!

http://pastebin.com/Zq3NDDeX

i'm patching mesa 9.2.0_rc1 to get this working.

Created attachment 84756 [details] [review]
fix multiple symbols bug

(In reply to comment #11)
> fix multiple symbols bug

Thanks for the patch, but I think it's more invasive than necessary. We'd like to retain the possibility of sharing code between radeonsi and r600g in the future.

Can you try if Johannes' patch from comment 8 fixes the problem?

Created attachment 84840 [details] [review]
move shared data on the top

just an hint

(In reply to comment #12)
> Can you try if Johannes' patch from comment 8 fixes the problem?

i tried the to use the relevant part of the patch:
i added '__attribute__((visibility("default")))' in front of r600_init_query_functions.
but it didn't works.

i'm not a mesa developer but i think that you should do something like this:
edit shared structs to have shared data at the top: see attached #84840
find every shared function and check that data accessed from function it's in the shared ones.
if not you have to do an "if(sizeof(arg) == sizeof(struct r600_struct))" to determine how to read/write that data.

a well-done job it's to make a folder with all the shared code ( function and structs ) and use hardware-specific wrappers functions.

happy developing guys :)

(In reply to comment #14)
> (In reply to comment #12)
> > Can you try if Johannes' patch from comment 8 fixes the problem?
> 
> i tried the to use the relevant part of the patch:
> i added '__attribute__((visibility("default")))' in front of
> r600_init_query_functions.
> but it didn't works.

No. The relevant part of my patch is to build libllvmradeon shared again.

It seems sb. ignored my warning:
https://bugs.freedesktop.org/show_bug.cgi?id=62226#c12
in this commit:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=914d797

> 
> i'm not a mesa developer but [...]

you should try this patch:
https://github.com/jobermayr/mesa/commit/619c251

applied your patch, got a missing mesalibdir error in automake.

added this:
dnl Where to install internal libraries
mesalibdir="\$(libdir)/mesa-${VERSION}"
AC_SUBST([mesalibdir])

to configure.ac to get automake works fine.

after a bit of compiling i get:
libtool: link: x86_64-pc-linux-gnu-gcc -shared  -fPIC -DPIC  .libs/libllvmradeon9.2.0-rc1_la-radeon_uvd.o .libs/libllvmradeon9.2.0-rc1_la-radeon_setup_tgsi_llvm.o .libs/libllvmradeon9.2.0-rc1_la-radeon_llvm_emit.o .libs/libllvmradeon9.2.0-rc1_la-radeon_llvm_util.o  -Wl,--whole-archive ../../../../src/gallium/auxiliary/.libs/libgallium.a -Wl,--no-whole-archive  -L/usr/lib64/llvm -lz -lpthread -lffi -ldl -lm -Wl,--as-needed -lrt -lelf  -march=corei7 -O0 -Wl,--no-undefined -Wl,-R -Wl,/usr/lib64/llvm -Wl,-O1   -Wl,-soname -Wl,libllvmradeon9.2.0-rc1.so -o .libs/libllvmradeon9.2.0-rc1.so
.libs/libllvmradeon9.2.0-rc1_la-radeon_setup_tgsi_llvm.o: In function `tgsi2llvmtype':
/var/tmp/portage/media-libs/mesa-9.2.0_rc1/work/Mesa-9.2.0-rc1/src/gallium/drivers/radeon/radeon_llvm.h:139: undefined reference to `LLVMInt32TypeInContext'

followed by hundreds of:
undefined reference to `LLVM$whatever'

probably it's missing a -lllvm when making the shared object.
but i read that llvm ldflag it's something special and need to be taken from llvm-config --ldflags output.
after a little search in mesa sources i find that a scons script ( never heard of this language before ) call env.ParseConfig on llvm-config output:
http://www.scons.org/doc/1.2.0/HTML/scons-user/c1814.html
https://github.com/jobermayr/mesa/blob/master/scons/llvm.py

how can i fix that?
thanks for your support :)

PS: i'm keeping using my dirty-patched version without problems ;)

i forget to give you the output of my llvm-config --ldflags:
-L/usr/lib64/llvm -Wl,-R -Wl,/usr/lib64/llvm  -lz -lpthread -lffi -lrt -ldl -lm

This one should compile (I forgot to adapt a few things after I moved it up in my patch series):
https://github.com/jobermayr/mesa/commit/7e31d65

Created attachment 85550 [details] [review]
link libradeon only once

Please try this patch.
libradeon will be linked in egl_gallium.so only once.

testing

bOOM

../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_blit.o): In function `r600_blit_decompress_depth':
r600_blit.c:(.text+0x1f00): multiple definition of `r600_blit_decompress_depth'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_blit.o):r600_blit.c:(.text+0x1fa0): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_blit.o): In function `r600_decompress_color_textures':
r600_blit.c:(.text+0x23c0): multiple definition of `r600_decompress_color_textures'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_blit.o):r600_blit.c:(.text+0x2780): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_query.o): In function `r600_init_query_functions':
r600_query.c:(.text+0x280): multiple definition of `r600_init_query_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_query.o):r600_query.c:(.text+0x2000): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_resource.o): In function `r600_init_screen_resource_functions':
r600_resource.c:(.text+0x40): multiple definition of `r600_init_screen_resource_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_resource.o):r600_resource.c:(.text+0x80): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_resource.o): In function `r600_init_context_resource_functions':
r600_resource.c:(.text+0x80): multiple definition of `r600_init_context_resource_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_resource.o):r600_resource.c:(.text+0xc0): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_texture.o): In function `r600_init_flushed_depth_texture':
r600_texture.c:(.text+0x14e0): multiple definition of `r600_init_flushed_depth_texture'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_texture.o):r600_texture.c:(.text+0x2e60): first defined here
../../../../src/gallium/drivers/radeon/.libs/libradeon.a(libradeon_la-radeon_llvm_emit.o): In function `radeon_llvm_compile':
radeon_llvm_emit.c:(.text+0x1eb): undefined reference to `elf_version'
radeon_llvm_emit.c:(.text+0x243): undefined reference to `elf_memory'
radeon_llvm_emit.c:(.text+0x255): undefined reference to `elf_getshdrstrndx'
radeon_llvm_emit.c:(.text+0x267): undefined reference to `elf_nextscn'
radeon_llvm_emit.c:(.text+0x27e): undefined reference to `gelf_getshdr'
radeon_llvm_emit.c:(.text+0x29b): undefined reference to `elf_strptr'
radeon_llvm_emit.c:(.text+0x2cf): undefined reference to `elf_getdata'
radeon_llvm_emit.c:(.text+0x37e): undefined reference to `elf_getdata'
collect2: error: ld returned 1 exit status
gmake[3]: *** [egl_gallium.la] Error 1

Created attachment 86034 [details] [review]
new attemp with LIBADD += $(ELF_LIB)

I hate this automake / libtool because mine seems to be smart and I don't see this errors ...

../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_blit.o): In function `r600_blit_decompress_depth':
r600_blit.c:(.text+0x1f00): multiple definition of `r600_blit_decompress_depth'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_blit.o):r600_blit.c:(.text+0x1fa0): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_blit.o): In function `r600_decompress_color_textures':
r600_blit.c:(.text+0x23c0): multiple definition of `r600_decompress_color_textures'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_blit.o):r600_blit.c:(.text+0x2780): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_query.o): In function `r600_init_query_functions':
r600_query.c:(.text+0x280): multiple definition of `r600_init_query_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_query.o):r600_query.c:(.text+0x2000): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_resource.o): In function `r600_init_screen_resource_functions':
r600_resource.c:(.text+0x40): multiple definition of `r600_init_screen_resource_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_resource.o):r600_resource.c:(.text+0x80): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_resource.o): In function `r600_init_context_resource_functions':
r600_resource.c:(.text+0x80): multiple definition of `r600_init_context_resource_functions'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_resource.o):r600_resource.c:(.text+0xc0): first defined here
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(r600_texture.o): In function `r600_init_flushed_depth_texture':
r600_texture.c:(.text+0x14e0): multiple definition of `r600_init_flushed_depth_texture'
../../../../src/gallium/drivers/r600/.libs/libr600.a(r600_texture.o):r600_texture.c:(.text+0x2e60): first defined here
collect2: error: ld returned 1 exit status
gmake[3]: *** [egl_gallium.la] Error 1
gmake[3]: Leaving directory `/var/tmp/portage/media-libs/mesa-9999/work/Mesa-9999-amd64/src/gallium/targets/egl-static'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/var/tmp/portage/media-libs/mesa-9999/work/Mesa-9999-amd64/src/gallium/targets'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/var/tmp/portage/media-libs/mesa-9999/work/Mesa-9999-amd64/src'
make: *** [all-recursive] Error 1

im using gentoo with mesa-9999 from x11 overlay and llvm-9999 as well, maybe is that

$ find src/gallium/drivers/ -name "*.la" -delete -o -name "*.a" -delete -o -name "*.so" -delete
$ make

to rebuild libradeon as well as libr600 and libradeonsi without linked-in libradeon ...

nope the same, i guess you have something in your branch different than mesa master maybe

Created attachment 86169 [details] [review]
New version.

I renamed r600_ functions to si_ in radeonsi to avoid duplicate symbols.
Some duplicate code is now in radeon/r600_{blit,texture}_common.{c,h}.

Tested on AMD Fusion [Radeon HD 6310].
Built with:
../configure --enable-xvmc --enable-vdpau --enable-texture-float --enable-debug --with-dri-drivers="" --with-gallium-drivers=r600,radeonsi --enable-dri --enable-glx --enable-osmesa --enable-gles1 --enable-gles2 --enable-openvg --enable-gbm --enable-xa --enable-gallium-egl --enable-gallium-llvm --enable-gallium-gbm --enable-r600-llvm-compiler --enable-opencl

many thanks for your hard work, ill test it tonight and report back

Sadly this patch breaks mesa to the point glamor/xinit/weston hangs my 7770

I have a working memory saving patch but I am not authorised to publish it.

Is this still an issue?

(In reply to comment #29)
> I have a working memory saving patch but I am not authorised to publish it.

What do you mean?

(In reply to comment #30)
> Is this still an issue?
> 
> (In reply to comment #29)
> > I have a working memory saving patch but I am not authorised to publish it.
> 
> What do you mean?

yes is still an issue

that Johannes Obermayr gave me a patch that fixed it but seems there is some issue with upstream and i don't have his autorization to publish the patch

I have a Radeon HD 7750 and I am hit by the same problem with Mesa 10.0.2.
Is there anything I can do to help you fix this bug?

Does this still happen with current Mesa Git master? There should no longer be any symbol clashes between radeonsi and r600g.

(In reply to comment #33)
> Does this still happen with current Mesa Git master? There should no longer
> be any symbol clashes between radeonsi and r600g.

Yes, fixed here with radeonsi and mesa-git

(In reply to comment #34)
> (In reply to comment #33)
> > Does this still happen with current Mesa Git master? There should no longer
> > be any symbol clashes between radeonsi and r600g.
> 
> Yes, fixed here with radeonsi and mesa-git

I'm closing this then.

Yes seems fully fuixed
El 14/01/2014 04:47, <bugzilla-daemon@freedesktop.org> escribió:

>   *Comment # 33 <https://bugs.freedesktop.org/show_bug.cgi?id=64810#c33>
> on bug 64810 <https://bugs.freedesktop.org/show_bug.cgi?id=64810> from
> Michel Dänzer <michel@daenzer.net> *
>
> Does this still happen with current Mesa Git master? There should no longer be
> any symbol clashes between radeonsi and r600g.
>
>  ------------------------------
> You are receiving this mail because:
>
>    - You reported the bug.
>
>

(In reply to comment #36)
> Yes seems fully fuixed

Is runtime memory usage as low as with my patch?

(In reply to comment #37)
> (In reply to comment #36)
> > Yes seems fully fuixed
> 
> Is runtime memory usage as low as with my patch?

seems so, but im not really sure if ksysguard is that exact