| Summary: | unify the 'next' version of constants, servicetest | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | general | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 69822, 69855, 69856 | ||
| Bug Blocks: | 69431 | ||
| Attachments: |
[mc/next] constants, servicetest: update to Telepathy 1
[haze/next] Sync constants, servicetest with MC's 'next' version [idle/next] Sync constants, servicetest with MC's 'next' version [salut/next] Sync constants, servicetest with MC's 'next' version |
||
|
Description
Simon McVittie
2013-09-26 17:32:41 UTC
Created attachment 86667 [details] [review] [mc/next] constants, servicetest: update to Telepathy 1 This is not as trivial as it might seem. Some (but not all!) interfaces have gained versioning (a trailing "1" in practice), some enums have been renumbered, and some things have been deleted. I'm reasonably sure this version is correct: I've tested it in Haze, Idle and Salut. --- This will make the 'next' branch fail its tests, but that's rather inevitable anyway while we do all the sed operations. Created attachment 86668 [details] [review] [haze/next] Sync constants, servicetest with MC's 'next' version --- Same files as Attachment #86667 [details]. Tests still pass, if the patches from Bug #69855 are applied to both tp-glib and Haze. Created attachment 86669 [details] [review] [idle/next] Sync constants, servicetest with MC's 'next' version --- Tests pass (tested with the telepathy-glib from Bug #69855, which I'll tag as 0.99.2 if approved). Created attachment 86670 [details] [review] [salut/next] Sync constants, servicetest with MC's 'next' version --- Tests pass, with the same tp-glib from Bug #69855. That's all for now. Comment on attachment 86667 [details] [review] [mc/next] constants, servicetest: update to Telepathy 1 Review of attachment 86667 [details] [review]: ----------------------------------------------------------------- ::: tests/twisted/servicetest.py @@ +604,4 @@ > return self.inspect_contacts_sync([handle])[0] > > def inspect_contacts_sync(self, handles): > + h2asv = self.Contacts.GetContactAttributes(handles, []) strictly speaking this is not related to this patch. Comment on attachment 86668 [details] [review] [haze/next] Sync constants, servicetest with MC's 'next' version Review of attachment 86668 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86669 [details] [review] [idle/next] Sync constants, servicetest with MC's 'next' version Review of attachment 86669 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 86670 [details] [review] [salut/next] Sync constants, servicetest with MC's 'next' version Review of attachment 86670 [details] [review]: ----------------------------------------------------------------- ++ (In reply to comment #5) > > + h2asv = self.Contacts.GetContactAttributes(handles, []) > > strictly speaking this is not related to this patch. It's a piece of code in the "unified" servicetest, that will no longer work in Telepathy 1. How is that not related? :-) Fixed in git for 0.99.2 (and in MC's new 'next' branch which doesn't work yet), thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.