| Summary: | polkitbackend: Fix error reporting when loading a config file | ||
|---|---|---|---|
| Product: | PolicyKit | Reporter: | Philip Withnall <bugzilla> |
| Component: | daemon | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
polkitbackend: Fix error reporting when loading a config file
0001-Remove-polkitbackendconfigsource.-ch.patch |
||
|
Description
Philip Withnall
2016-03-23 10:18:59 UTC
Created attachment 122493 [details] [review] polkitbackend: Fix error reporting when loading a config file The GError* was not being passed to g_key_file_load_from_file(), but was being used in the error handling for when it failed, which would have caused a NULL pointer dereference. Spotted by Coverity (CID: #77843). Created attachment 122496 [details] [review] 0001-Remove-polkitbackendconfigsource.-ch.patch Thanks for your report. In fact, that file is not used by anything any more, so we should just remove it. Comment on attachment 122496 [details] [review] 0001-Remove-polkitbackendconfigsource.-ch.patch Review of attachment 122496 [details] [review]: ----------------------------------------------------------------- Yep, last reference was 0f830c76048229895164837f8ce01869d88a2616. LGTM, thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.