Bug 94670 - polkitbackend: Fix error reporting when loading a config file
Summary: polkitbackend: Fix error reporting when loading a config file
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 10:18 UTC by Philip Withnall
Modified: 2016-03-29 11:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
polkitbackend: Fix error reporting when loading a config file (1.30 KB, patch)
2016-03-23 10:19 UTC, Philip Withnall
Details | Splinter Review
0001-Remove-polkitbackendconfigsource.-ch.patch (24.98 KB, patch)
2016-03-23 12:20 UTC, Miloslav Trmac
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Withnall 2016-03-23 10:18:59 UTC
Trivial patch attached.
Comment 1 Philip Withnall 2016-03-23 10:19:01 UTC
Created attachment 122493 [details] [review]
polkitbackend: Fix error reporting when loading a config file

The GError* was not being passed to g_key_file_load_from_file(), but was
being used in the error handling for when it failed, which would have
caused a NULL pointer dereference.

Spotted by Coverity (CID: #77843).
Comment 2 Miloslav Trmac 2016-03-23 12:20:28 UTC
Created attachment 122496 [details] [review]
0001-Remove-polkitbackendconfigsource.-ch.patch

Thanks for your report.

In fact, that file is not used by anything any more, so we should just remove it.
Comment 3 Colin Walters 2016-03-26 13:26:54 UTC
Comment on attachment 122496 [details] [review]
0001-Remove-polkitbackendconfigsource.-ch.patch

Review of attachment 122496 [details] [review]:
-----------------------------------------------------------------

Yep, last reference was 0f830c76048229895164837f8ce01869d88a2616.  LGTM, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.