Created attachment 130901 [details] [review]
Map evdev keycode KEY_FAVORITES to XF86Favorites

NB: The value of KEY_FAVORITES is 0x16c (364) and thus beyond 255,
which is not supported by X11. It might also need a recent xkbcomp
that is patched so it does not throw fatal errors for those. See
https://lists.x.org/archives/xorg-devel/2017-April/053389.html

https://bugs.freedesktop.org/show_bug.cgi?id=100709

Signed-off-by: Christian Kellner <christian@kellner.me>

Is it safe from x11 POV to have codes >255 ?

As long as xkbcomp (as in the link) is patched, then yes, it'll just be ignored. Without that fix, it's a fatal error.

Is the current version of xorg patched? Or is it only in DEV branch? I would not like to have that included before the stable xorg can handle it.

There hasn't been a combined 'katamari' release since 7.7, which was 5 years ago now. I don't expect there will be another one either. But I guess we could contact all the distros individually and ask them to make sure they update xkbcomp. How long would you like to wait, or would it be based on xkbcomp entering particular distros, or ... ?

Ok, hypocrisy aside, where are RedHat and Debian now in relation to that code?

(In reply to Sergey V. Udaltsov from comment #6)
> Ok, hypocrisy aside, where are RedHat and Debian now in relation to that
> code?

Neither have shipped it :)

Perhaps I should wait a bit then... September release may be (considering that May release is going to happen soon)

KEY_KEYBOARD too, please? :)

$ sudo libinput-debug-events --device /dev/input/event4
-event4   DEVICE_ADDED     ThinkPad Extra Buttons            seat0 default group1  cap:k
 event4   KEYBOARD_KEY      +1.69s      KEY_FAVORITES (364) pressed
 event4   KEYBOARD_KEY      +1.69s      KEY_FAVORITES (364) released
 event4   KEYBOARD_KEY      +1.95s      KEY_KEYBOARD (374) pressed
 event4   KEYBOARD_KEY      +1.95s      KEY_KEYBOARD (374) released

(In reply to Damjan Georgievski from comment #9)
> KEY_KEYBOARD too, please? :)
I filed bug #101521 for that.

Created attachment 139262 [details] [review]
Map evdev keycode KEY_FAVORITES to XF86Favorites

Patch rebased to master

Thanks committed!