Created attachment 132090 [details] [review]
Map evdev keycode KEY_KEYBOARD to XF86Keyboard

NB: XF86Keyboard is a relatively new keysym and therefore needs
recent protocol headers. Also KEY_KEYBOARD's keysym is > 255
and therefore needs a recent xkbcomp (as the new KEY_FAVORITES).

https://bugs.freedesktop.org/show_bug.cgi?id=101521

Signed-off-by: Christian Kellner <christian@kellner.me>

It's customary to say what the key might "do" when pressed, or if it corresponds to a HID key.

(In reply to Bastien Nocera from comment #2)
> It's customary to say what the key might "do" when pressed, or if it
> corresponds to a HID key.

Yes please give some more details. Also, your patch does not work with the current git, could you please amend? Thank you

I assume the patch doesn't apply because I based it on top of patch for  KEY_FAVORITES, because I had hoped that the former would be committed by the time this gets reviewed. 
Want make a version of this patch against master?

About the "details" part: surprisingly hard for this key. The target XF86XK_Keyboard is also new, and the description was left vague ("User defined keyboard related action") because there is not a clear, unambiguous function associated with it.
On Windows and Lenovo Hardward it will bring up the general keyboard settings dialog, but it was generally agreed upon that this is kinda useless and we (GNOME) will probably use it for something else (switching keyboard layouts or something). Not sure what or if KDE will do something with it.
FWIW, I also think the mapping file is probably not the right place to document behaviour -- and the mapping of KEY_KEYBOARD to XF86XK_Keyboard is kinda straight forward and obvious. I will happily add something though if you think that is usefull. Maybe the same as for XF86XK_Keyboard ("User defined keyboard related action")?

> Want make a version of this patch against master?
Yes please!

> About the "details" part: surprisingly hard for this key. The target
> XF86XK_Keyboard is also new, and the description was left vague ("User
> defined keyboard related action") because there is not a clear, unambiguous
> function associated with it.
I see.. We have to come up with something though. Let's define our standard here:)

> you think that is usefull. Maybe the same as for XF86XK_Keyboard ("User
> defined keyboard related action")?
That sounds fair. Let's do it that way.

Hey, what is the status on the mapping to be added?

I was about to modify the default settings in GNOME so that the key will be used to switch the keyboard layout (in addition to "<Super>space"), but than realised that the mapping is not there yet.

Even if it will not work on X11, could the mapping be added so that we can support the key on wayland systems?

sorry your patch does not apply to git. Could you please check and fix?

Created attachment 139263 [details] [review]
Map evdev keycode KEY_KEYBOARD to XF86Keyboard

Patch rebased to master. https://bugs.freedesktop.org/show_bug.cgi?id=100709 is required to apply it cleanly.

Thank you, done!