Failing tests: bin/arb_gpu_shader5-interpolateAtSample -auto -fbo bin/arb_gpu_shader5-interpolateAtSample-nonconst -auto -fbo Bisection result: eb8aa93c03ee89ffd3041d41b6293e4b282b6ce6 is the first bad commit commit eb8aa93c03ee89ffd3041d41b6293e4b282b6ce6 Author: Timothy Arceri <tarceri@itsqueeze.com> Date: Fri Apr 14 16:25:58 2017 +1000 glsl: disable varying packing for varying used by interpolateAt* Currently the NIR backends depend on GLSL IR copy propagation to fix up the interpolateAt* function params after varying packing changes the shader input to a global. It's possible copy propagation might not always do what we need it too, and we also shouldn't depend on optimisations to do this type of thing for us. I'm not sure if the same is true for TGSI, but the following commit should re-enable packing for most cases in a safer way, so we just disable it everywhere. No change in shader-db for i965 (BDW) Acked-by: Elie Tournier <elie.tournier@collabora.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reverting the commit fixes the problem.
Ah, a fail output: $ LD_LIBRARY_PATH=/home/constantine/Projects/mesa/lib LIBGL_DRIVERS_PATH=/home/constantine/Projects/mesa/lib/gallium /home/constantine/Projects/piglit/bin/arb_gpu_shader5-interpolateAtSample -auto -fbo Probe color at (0,0) Expected: 0 255 0 Observed: 20 195 0 PIGLIT: {"result": "fail" }
Does it work if you set: R600_DEBUG=nosb Also it would be helpful if you could attach a before and after shader dump using. R600_DEBUG=vs,ps
(In reply to Timothy Arceri from comment #2) > Does it work if you set: > > R600_DEBUG=nosb Yeah, this way it does pass. > Also it would be helpful if you could attach a before and after shader dump > using. > > R600_DEBUG=vs,ps Attaching.
Created attachment 131043 [details] ps,vs dump HEAD
Created attachment 131044 [details] ps,vs dump HEAD with reverted eb8aa93c03
Thanks. Looks like a bug in sb optimisations so the output of R600_DEBUG=vs,ps,nosb on HEAD would also be useful.
Created attachment 131062 [details] ps,vs,nosb dump HEAD
Created attachment 131063 [details] ps,vs,nosb dump HEAD with reverted eb8aa93c03
Hmm, wait. Now for some reason it fails with nosb also.
Not sure why, but I can't get it passing with "nosb" anymore :(
So, actually there're 4 different combinations: | usual run | nosb | HEAD | fails | passes| HEAD eb8aa93c03 reverted | passes | fails | With that said, I've attached dumps for all 4 configurations. But I do actually recall that "nosb" option was buggy, see this https://bugs.freedesktop.org/show_bug.cgi?id=93715
(EDIT: replaced tabs with space in the table) So, actually there're 4 different combinations: | usual run | nosb | HEAD | fails | passes| HEAD eb8aa93c03 reverted | passes | fails | With that said, I've attached dumps for all 4 configurations. But I do actually recall that "nosb" option was buggy, see this https://bugs.freedesktop.org/show_bug.cgi?id=93715
Possible fix https://lists.freedesktop.org/archives/mesa-dev/2017-June/159872.html It solves the problem, but needs more work to exclude other bugs of alike type.
Created attachment 132157 [details] [review] fix FTR, attaching the fix. However I don't know when I get it sent to the ML because I can't finish piglit testing — GPU hangs.
Fixed by https://cgit.freedesktop.org/mesa/mesa/commit/?id=3d466f3e9f76c91083f0cfbb8a76148bdb0d52a3
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.