Bug 12816 - New layouts for br (Brazil), pt (Portugal) and epo (Esperanto)
Summary: New layouts for br (Brazil), pt (Portugal) and epo (Esperanto)
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL: http://tecladobrasileiro.com.br
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-15 18:35 UTC by Ari Caldeira
Modified: 2007-10-20 09:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to include br(dvorak) into rules/base (583 bytes, patch)
2007-10-15 18:36 UTC, Ari Caldeira
Details | Splinter Review
Patch to include br, pt and epo new variants into base.lst (1.27 KB, patch)
2007-10-15 18:39 UTC, Ari Caldeira
Details | Splinter Review
Patch to include br, pt and epo new variants into base.xml (2.40 KB, patch)
2007-10-15 18:40 UTC, Ari Caldeira
Details | Splinter Review
Includes 3 new variants into symbols/br (12.06 KB, patch)
2007-10-15 18:43 UTC, Ari Caldeira
Details | Splinter Review
Includes 2 new variants into symbols/epo (1.97 KB, patch)
2007-10-15 18:44 UTC, Ari Caldeira
Details | Splinter Review
Includes 2 new variants into symbols/pt (5.74 KB, patch)
2007-10-15 18:45 UTC, Ari Caldeira
Details | Splinter Review
Minor improvements in geometry/pc abnt2 description (4.85 KB, patch)
2007-10-15 18:54 UTC, Ari Caldeira
Details | Splinter Review
Patch to source file rules/base.xml.in (2.23 KB, patch)
2007-10-16 17:04 UTC, Ari Caldeira
Details | Splinter Review
Patch to source file rules/compat/base.lists.part (269 bytes, patch)
2007-10-16 17:05 UTC, Ari Caldeira
Details | Splinter Review
One patch to patch them all (27.73 KB, patch)
2007-10-18 05:31 UTC, Ari Caldeira
Details | Splinter Review

Description Ari Caldeira 2007-10-15 18:35:42 UTC
Patches to include the Nativo keyboard layout for Brazil, Portugal, and Esperanto.

This is a layout created about 2 years ago, a Dvorak-style layout designed specific for the Portuguese language, in its variants for Brazilian and Portuguese keyboards, as well for direct typing Esperanto.
Comment 1 Ari Caldeira 2007-10-15 18:36:56 UTC
Created attachment 12057 [details] [review]
Patch to include br(dvorak) into rules/base
Comment 2 Ari Caldeira 2007-10-15 18:39:13 UTC
Created attachment 12058 [details] [review]
Patch to include br, pt and epo new variants into base.lst

I saw that OLPC has recently commited a serias of new layout variants.

This patch also includes the brazilian OLPC layout variant into rules/base.lst
Comment 3 Ari Caldeira 2007-10-15 18:40:21 UTC
Created attachment 12059 [details] [review]
Patch to include br, pt and epo new variants into base.xml

This patch also includes the brazilian OLPC layout variant into rules/base.xml
Comment 4 Ari Caldeira 2007-10-15 18:43:11 UTC
Created attachment 12060 [details] [review]
Includes 3 new variants into symbols/br

Patch to include 3 new variants into symbols/br:

nativo: http://tecladobrasileiro.org/nativo/br-nativo-padrao.html
nativo-usa: http://tecladobrasileiro.org/variante/versao-internacional.html
dvorak: http://tecladobrasileiro.org/dvorak/br-dvorak.html
Comment 5 Ari Caldeira 2007-10-15 18:44:23 UTC
Created attachment 12061 [details] [review]
Includes 2 new variants into symbols/epo

Patch to include 2 new variants into symbols/epo:

br-nativo and pt-nativo: http://tecladobrasileiro.org/variante/versao-esperanto.html
Comment 6 Ari Caldeira 2007-10-15 18:45:58 UTC
Created attachment 12062 [details] [review]
Includes 2 new variants into symbols/pt

Patch to include 2 new variants into symbols/pt:

nativo: http://tecladobrasileiro.org/nativo/pt-nativo-padrao.html
nativo-usa: http://tecladobrasileiro.org/variante/versao-internacional.html
Comment 7 Ari Caldeira 2007-10-15 18:54:08 UTC
Created attachment 12063 [details] [review]
Minor improvements in geometry/pc abnt2 description

Patch to clean-up the code in geometry/pc abnt2 description; it now includes pc(pc105) and changes just what is realy different.
Comment 8 Sergey V. Udaltsov 2007-10-16 01:11:17 UTC
Could you please have a look at the submission rules (http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules) and, instead of patching base/base.lst/base.xml patch the actual source files instead?
Thanks.
Comment 9 Ari Caldeira 2007-10-16 17:04:25 UTC
Created attachment 12081 [details] [review]
Patch to source file rules/base.xml.in
Comment 10 Ari Caldeira 2007-10-16 17:05:04 UTC
Created attachment 12082 [details] [review]
Patch to source file rules/compat/base.lists.part
Comment 11 Ari Caldeira 2007-10-16 17:07:59 UTC
(In reply to comment #8)
> Could you please have a look at the submission rules
> (http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules) and, instead
> of patching base/base.lst/base.xml patch the actual source files instead?
> Thanks.
> 

Sorry, Sergey, I missed reading those rules.

Just added the patches to the source files. After you understand that most part comes from base.xml.in, things start to get clearer :)

Thank you!

Comment 12 Sergey V. Udaltsov 2007-10-17 01:44:34 UTC
That's better. Now, more questions. You are putting country-specific Esperanto variants into into epo file. Would you consider putting them into pt and br files instead? I know, there is some ambiguity here - but I prefer to keep the codebase organized as "per-country" as possible. Epo layout is a special thing here (oh I have exceptions:) - but at least I am trying to keep it really country-neutral.

PS And when we finish our discussion - could you please make it a single large patch?

Thanks!
Comment 13 Ari Caldeira 2007-10-17 07:27:44 UTC
(In reply to comment #12)
> That's better. Now, more questions. You are putting country-specific Esperanto
> variants into into epo file. Would you consider putting them into pt and br
> files instead? I know, there is some ambiguity here - but I prefer to keep the
> codebase organized as "per-country" as possible. Epo layout is a special thing
> here (oh I have exceptions:) - but at least I am trying to keep it really
> country-neutral.
> 

I've put the br and pt variants into epo becouse if the user chooses the keyboard map via Gnome or KDE, it would make more sense that he finds those variants into the Esperanto listbox/combobox.

Would it be ok for you to put them on both epo and br/pt? I moved them into br and pt, renamed them to nativo-epo, and in epo I simply included br(nativo-epo) and pt(nativo-epo). That way the user can choose via br(nativo-epo)/pt(nativo-epo) or epo(nativo-br)/epo(nativo-pt).

If thats ok, I'll send the patch right away.
Comment 14 Sergey V. Udaltsov 2007-10-17 14:21:19 UTC
> I've put the br and pt variants into epo becouse if the user chooses the
> keyboard map via Gnome or KDE, it would make more sense that he finds those
> variants into the Esperanto listbox/combobox.
As I said, I'd prefer to keep esp layout country-neutral (and as small as possble). That's similar to the current policy for dvorak - these variants are put in the respective countries' layouts.

> Would it be ok for you to put them on both epo and br/pt? 
I would prefer not to do it. Because it defeats the whole idea of country-neutral epo.
Comment 15 Ari Caldeira 2007-10-18 05:27:30 UTC
(In reply to comment #14)
> As I said, I'd prefer to keep esp layout country-neutral (and as small as
> possble). That's similar to the current policy for dvorak - these variants are
> put in the respective countries' layouts.

Hum, now I see your point :-)

Thank you!

I'll send the new patch without any modifications to symbols/epo.
Comment 16 Ari Caldeira 2007-10-18 05:31:59 UTC
Created attachment 12105 [details] [review]
One patch to patch them all

Patches geometry/pc, symbols/br, symbols/pt, rules/base.xml.in, rules/compat/base.lists.part
Comment 17 Sergey V. Udaltsov 2007-10-18 13:46:18 UTC
Great! Committed (with some minor changes)
Comment 18 Ari Caldeira 2007-10-20 09:59:09 UTC
(In reply to comment #17)
> Great! Committed (with some minor changes)
> 

Thank you, very much!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.