I've created the patch. The purpose is to provide a way to type Esperanto characters without changing the layout. This is very useful for people that are not working all the time in Esperanto, but want to type Esperanto from time to time. Basically the third level group or whatever is called for each letter has the corresponding letter with supersigno (hat).
Ideally, this should be a keyboard modifier that can be applied to any keyboard, like the Euro stuff, but honestly, I couldn't make that work so I couldn't develop it.

1. Your base version of xkeyboard-config is rather old. Could you please base your patch against the latest version (preferable - git)
2. You are patching symbols/us. But there is already symbols/epo - would you have a look at it please?

Thanks

Hello,

The epo layouts, I understand, are for cases where Esperanto is the main language. But this patch is for when Esperanto is the second language and it is used only sporadically, and where the main language is English.

Where is the Git repository so I can update the patch?

Thanks.

http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Development

Created attachment 20687 [details] [review]
Patch adding eo characters

This is a much better patch that the one before because it separates the Esperanto characters from the layouts and adds them as options which could be added to any layout. Like the eurosign.

Oh, and the last patch is for version 1.3. Hope that's recent enough.

I DO like the idea to have it as an option. But in that case I'd drop the variants of 'us' layout. 
Also, patching base.lst is redundant. And finally - why not just add symbols to symbols/epo file?

I hesitated about adding the US layouts, as I'm making Ubuntu packages out of this patch, I maintained the US for backwards compatibility. I'll create another patch and I'll send it.
I also considered adding it to the epo file, I'll do that as well. But I'll do it as a git patch.
Also, epo is the three letter code for Esperanto, but all the other languages use a two letter code. Would you accept if I move (as a separated git patch) epo to eo?
Thanks.

> I also considered adding it to the epo file, I'll do that as well. But I'll do
> it as a git patch.
No problem.

> Also, epo is the three letter code for Esperanto, but all the other languages
> use a two letter code. Would you accept if I move (as a separated git patch)
> epo to eo?
Please do not do that. I intentionally use 3-letter filenames for all layouts which are not country-based. Like Esperanto.

I've ported the changes to the Git repository. You can pull from here: git://github.com/pupeno/xkeyboard-config.git

No problem, haven't renamed epo.

Just as a shortcut, this is my patch:

http://github.com/pupeno/xkeyboard-config/commit/3dd391ecec25a825dee770e8a10c233b8cba70d5

If you see anything wrong there, just let me know and I'll fix it.

Two issues: no need to patch Makefile.am - and base.o_s.part still refers to the esperanto file.

Fixed and pushed.

It is all fine on the web, but it is all colored etc. How could I get your patches in plain text (without git pull, which somehow fails for me)

Created attachment 20692 [details] [review]
First git patch

Created attachment 20693 [details] [review]
Second git patch

Those are the two patches as created by git format-patch origin, I'm not sure how else to generate them, but they should be directly importable into a git repo with git am I believe.

Just sweet! Thanks, committed.

Sergey,

After using this patch for some days I've realized something. At least with Ubuntu you can have only one global set of layout options. It means that you can set one of the two. If you are like me and you switch between Dvorak and Qwerty, then you have a problem. Is this an Ubuntu limitation or an Xorg limitation? If it is an Xorg limitation, then it might make sense to add two USA layouts with Esperanto keyboard.
What do you think?

Thanks.

(In reply to comment #20)
> Sergey,
> 
> After using this patch for some days I've realized something. At least with
> Ubuntu you can have only one global set of layout options. It means that you
> can set one of the two. If you are like me and you switch between Dvorak and
> Qwerty, then you have a problem. Is this an Ubuntu limitation or an Xorg
> limitation? If it is an Xorg limitation, then it might make sense to add two
> USA layouts with Esperanto keyboard.
> What do you think?

It is not clear what exactly is not working.
Are you unable to use shortcuts (such as Alt+F to open the File menu)?
Are you unable to type individual keys?

No, the problem is this. I have two layouts: "USA" and "USA Dvorak" and switch between them. Now, which one should I use? "Esperanto for Qwerty" or "Esperanto for Dvorak"? one of the two is going to be wrong some times, while having "USA Esperanto" and "USA Dvorak Esperanto" works all the time.

We can leave it to the user - as 2 options?

But as I see, the user has no way of choosing the Qwerty Esperanto layout option for the Qwerty keyboard *and* the Dvorak Esperanto layout option for the Dvorak keyboard because the layout options are global, not per keyboard layout.

It is even worse than that. Options are not global. They are applied to the first layout (unless they mention groups>=2 explicitly). There is separate bug to make options _really_ global.

But it does not affect my unwillingness to create slightly bloatish Dvorak variants for US layout.

That's most unfortunate. Where can I submit those other bugs? (that is, inability to set up layout options per keyboard).

Option per layout? Here. Against xorg (component Input/XKB I guess). When you file that bug - please put the number here in comments.

Ok, made the other report: #19004

Closing; this bug was fixed long ago.  This also fixed bug #8585.
It does not depend on bug #19004 which is about having options per layout --
although a fix for that bug would make this fix more useful for some people.