Bug 1934 - DPMS*Time == 0 doesn't disable DPMS timer like it should.
Summary: DPMS*Time == 0 doesn't disable DPMS timer like it should.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.8.1
Hardware: All All
: high normal
Assignee: Egbert Eich
QA Contact:
URL:
Whiteboard:
Keywords:
: 792 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-26 06:36 UTC by Egbert Eich
Modified: 2004-12-11 22:48 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] Fix (1.25 KB, patch)
2004-11-26 06:37 UTC, Egbert Eich
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Egbert Eich 2004-11-26 06:36:37 UTC
Patch fixes SetDPMSTimers() so that DPMS*Time == 0 disables the
appropriate timer. This takes advantage of the fact that
TimerSet() with a timeout argument 0 behaves like TimerCanel().

Already committed to HEAD. For 6.8.2 nomination only.
Comment 1 Egbert Eich 2004-11-26 06:37:46 UTC
Created attachment 1393 [details] [review]
[FIXED_X11R68x] Fix

See previous comment.
Comment 2 Roland Mainz 2004-12-08 06:07:45 UTC
Comment on attachment 1393 [details] [review]
[FIXED_X11R68x] Fix

Approved in the 2004-12-06 release-wranglers conference call.
Please do not commit it yourself, I'll do that later today...
Comment 3 Donnie Berkholz 2004-12-09 09:58:56 UTC
*** Bug 792 has been marked as a duplicate of this bug. ***
Comment 4 Roland Mainz 2004-12-12 17:46:41 UTC
Comment on attachment 1393 [details] [review]
[FIXED_X11R68x] Fix

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.23; previous revision: 1.365.2.22
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/os/WaitFor.c,v  <--  WaitFor.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 5 Roland Mainz 2004-12-12 17:48:11 UTC
Patch has been commited to Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED (please reopen if there are any issues left).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.