Bug 792 - Screen blanks / DPMS activates while desktop is in use
Summary: Screen blanks / DPMS activates while desktop is in use
Status: RESOLVED DUPLICATE of bug 1934
Alias: None
Product: xorg
Classification: Unclassified
Component: Release (show other bugs)
Version: 6.7.0
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-22 07:43 UTC by Jonathan Rawle
Modified: 2004-12-08 18:35 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
cleanroomed patch from Gentoo (1007 bytes, patch)
2004-11-22 03:39 UTC, Daniel Stone
roland.mainz: 6.8-branch-
Details | Splinter Review

Description Jonathan Rawle 2004-06-22 07:43:21 UTC
Since installing Fedora Core 2, my screen blanks 30 miuntes after starting X, 
and again 10 minutes later. This happens regardless of whether I am 
typing/moving the mouse or not. After the screen blanks, my monitor goes into 
standby. Other people have reported similar behaviour with FC2, and also with 
other distros using xorg such as Gentoo. It also appears to happen for people 
using different desktop environments, and at the graphical login screen.
Comment 1 Stephen Chao 2004-08-11 13:14:29 UTC
This bug existed in xfree86 4.4.0.  I submitted a bug report there:
http://bugs.xfree86.org/show_bug.cgi?id=1252
...and now my distribution (Slackware) decides to switch, so here I am posting it again :P

Seems to be about forgetting to clear the timer in WaitFor.c
I can't imagine anyone not having this issue in either x.org or xfree86 4.4.0.  I'm surprised there hasn't 
been a bigger fuss about it.
Comment 2 Rotem Zach 2004-08-19 13:49:48 UTC
I am getting this also and I am using gentoo. It seems that XFREE have fixed it
so maybe if the file is still under teh old licsence we can get teh fix from
them. I also wonder how come there hasnt been a bigger fuss over this.
Comment 3 Donnie Berkholz 2004-08-20 21:53:34 UTC
Dawes committed the fix April 7. Draw your own conclusions on the resultant
license. Some more info at
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=120817,
http://bugs.gentoo.org/show_bug.cgi?id=47922 and
http://bugs.xfree86.org/show_bug.cgi?id=1252.
Comment 4 Jim Gettys 2004-08-21 10:28:50 UTC
I'm not sure this should block the release, but I am sure it should
be talked about on the next call, and to make people aware of the
bug that people are noticing alot.
Comment 5 Niek v/d Maas 2004-08-25 03:46:59 UTC
FYI, the fix is here:
http://cvsweb.xfree86.org/cvsweb/xc/programs/Xserver/os/WaitFor.c.diff?r1=3.45&r2=3.46

Isn't is possible to integrate this patch into XOrg? I think it's kinda silly
that a license change makes adding 3 if-checks impossible.
Comment 6 Jonathan Rawle 2004-08-26 03:41:20 UTC
I found a work-around for this problem. In the ServerLayout section I added: 
 
        Option         "StandbyTime"  "30" 
        Option         "SuspendTime"  "0" 
        Option         "OffTime"  "0" 
 
The unwanted blanking no longer occurs. Even better, once I'm logged in I can 
change the DPMS settings using xset (or the Control Centre in KDE) and these 
work as expected. Changing the settings here doesn't bring the problem back 
again. 
Comment 7 Mike A. Harris 2004-08-27 04:30:58 UTC
David Dawes has repeatedly said any code he commits to CVS is under the
XFree86 1.1 license.

Many people give opinions, including lawyers, that small obvious bug
fixes is not copyrightable at all, so in theory, including some small
obvious bugfixes which happen to be committed by David is theoretically
possible with good odds of winning a copyright lawsuit.

The question is then wether such a lawsuit would be tested in court, and
who is willing to find out.  In all likelyhood, the odds are that such
a frivolous lawsuit would cost the person suing, to spend a lot of money,
and lose their case.  It would also needlessly waste a lot of people's time.

Why bother?  Really?

It's not much more difficult to get someone to read the code, and then
describe the changes in a non-specific way which generically describes the
problem and the solution without mentioning code specifics, then having
someone else who hasn't ever looked at the XFree86 code for the fix to
go ahead and re-implement it.

Nobody is going to just wholesale copy code from XFree86 to X.Org however
in which there is any question about legal issues pertaining to copyright,
trademark, patent, or other intellectual property law.
Comment 8 Daniel Stone 2004-11-12 03:46:55 UTC
In xc/programs/Xserver/os/WaitFor.c, at the end of the file, there is a function
named SetDPMSTimers.  Three timers are checked in sequence; if the time value is
greater than zero, then the timers are set accordingly.

For each of these timers, if this condition is NOT met, then they need to be
cancelled.

(Someone else needs to implement this, I've just looked at the code.)
Comment 9 Donnie Berkholz 2004-11-15 09:10:03 UTC
Tavin Cole was kind enough to (re-)implement a fix. Please take a look at it.
The direct link is http://bugs.gentoo.org/attachment.cgi?id=43761 and more info
is at http://bugs.gentoo.org/show_bug.cgi?id=47922#c36.
Comment 10 Daniel Stone 2004-11-22 03:39:14 UTC
Created attachment 1323 [details] [review]
cleanroomed patch from Gentoo
Comment 11 Daniel Stone 2004-11-22 03:40:00 UTC
Comment on attachment 1323 [details] [review]
cleanroomed patch from Gentoo

oh man, please please include this for 6.8.2, it's been the biggest source of
annoyance for Ubuntu users
Comment 12 Roland Mainz 2004-12-08 06:05:55 UTC
Comment on attachment 1323 [details] [review]
cleanroomed patch from Gentoo

Approval denied in the 2004-12-06 release-wranglers call, we're taking the the
patch in bug 1934 instead.
Comment 13 Daniel Stone 2004-12-09 03:00:27 UTC
since the patch in 1394 got accepted, despite the fact that 1394 is a dup of
792, close this as a dup of 1394 as the patch in 1394 is the relevant one

*** This bug has been marked as a duplicate of 1394 ***
Comment 14 Donnie Berkholz 2004-12-09 09:58:44 UTC
Wrong dup.
Comment 15 Donnie Berkholz 2004-12-09 09:58:54 UTC

*** This bug has been marked as a duplicate of 1934 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.