Created attachment 33709 [details] [review]
Ortho file

Ping for feedback on attached patch.

Can we have fontconfig update before Final freeze of Fedora 13 development cycle?

Behdad,
Fedora 13 Final freeze is due on tomorrow. Can we have new fontconfig built in Fedora 13 before that?

Fedora 14 is already out since a month and still we are waiting for this fix to be included in fontconfig.

Please, can someone look into this and commit attached patch and release new fontconfig?

Thanks.

Why not just sd_IN.orth?

(In reply to comment #6)
> Why not just sd_IN.orth?

I assumed ortho file name should be same as locale file name. If this assumption is wrong then please use sd_IN.orth name.

(In reply to comment #7)
> (In reply to comment #6)
> > Why not just sd_IN.orth?
> 
> I assumed ortho file name should be same as locale file name. If this
> assumption is wrong then please use sd_IN.orth name.

You didn't provide any comment or link suggesting what the locale name is either.  You provided zero references in fact.  Please link to the locale entry so I can confirm.  Same about the other orth bugs of yours.  Thanks.

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Why not just sd_IN.orth?
> > 
> > I assumed ortho file name should be same as locale file name. If this
> > assumption is wrong then please use sd_IN.orth name.
> 
> You didn't provide any comment or link suggesting what the locale name is
> either.  You provided zero references in fact.  Please link to the locale entry
> so I can confirm.  Same about the other orth bugs of yours.  Thanks.

Sorry I forgot the locale reference. This file can be found in Fedora 14 at location /usr/share/i18n/locales/sd_IN\@devanagari

Also tried to give glibc git url but its down with error "
503 - The load average on the server is too high"

Once server is back, i will provide online link also.

Thanks.  Please double check with hi.orth.  For those that are quite similar to hi.orth, please just include it.  If the difference is small, you can exclude characters from hi.orth.  See ne.orth for example.

Also, please comment out abbreviation sign, etc, the same way that hi.orth has done.

When you're done with all of these, please push a git repo out somewhere so I can pull.

Thanks

I have updated Indic ortho files in local git checkout and copied that directory to http://paragn.fedorapeople.org/fontconfig/

If needed only git patch then http://paragn.fedorapeople.org/0001-Update-for-Indic-languages-ortho-files.patch

ping behdad

*** Bug 27850 has been marked as a duplicate of this bug. ***

Created attachment 57568 [details] [review]
Sindhi using devanagari script ortho file

updated patch

The language model in fontconfig isn't the same to the locale. so adding the script modifier following @ doesn't look correct to me. if we really need to have some variants like this, it has to be addressed first.

I'll think about it once next release is out.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/101.