Bug 2676 - some i18n changes/corrections
Summary: some i18n changes/corrections
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: * Other (show other bugs)
Version: git
Hardware: All All
: high enhancement
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 708 3103 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-08 07:42 UTC by Pablo Saratxaga
Modified: 2011-10-15 16:23 UTC (History)
8 users (show)

See Also:
i915 platform:
i915 features:


Attachments
patch the removes some never unused encodings, renames koi8-c -> koi8-k and improves default UTF-8 XLC_LOCALE font list (37.57 KB, patch)
2005-03-08 07:45 UTC, Pablo Saratxaga
no flags Details | Splinter Review
XLC_LOCALE file of Solaris 10 en_US.UTF-8 locale for reference (5.89 KB, text/plain)
2005-03-09 22:28 UTC, Ienup Sung
no flags Details
patch to give priority to various 8bit encodings (iso8859-*, koi8-{r,u}, tisc620-0,...) before the CJK ones and the unicode one; (4.09 KB, patch)
2008-02-20 18:12 UTC, ojab
no flags Details | Splinter Review

Description Pablo Saratxaga 2005-03-08 07:42:04 UTC
The attached patch does some i18n/changes corrections;
it is what is used in Mandrakelinux packaging of xorg
Here it what it does:

- renames "koi8-c" encoding to "koi8-k" ("koi8-c" actually exists
  and is used (in non-X11 systems) for a *different* encoding,
  so it is misleading to use that naming here; note however
  that this "koi8-k" is not a standard encoding, it is unique
  to XFree86/Xorg, and was created (by me) at a time when
  unicode support was not yet functional, as a way to be able
  to display some cyrillic chars not covered by the already
  existing encodings. It is not used any longer in Mandrakelinux
  and I doubt it is still used anywhere; so it could be
  completly removed maybe)
- removes "isiri-3342" and "nokhchi-1" which AFAIK had never
  ever been used.
- rewrite of en_US.UTF-8 XLC_LOCALE so it gives priority
  to various 8bit encodings (iso8859-*, koi8-{r,u}, tisc620-0,...)
  before the CJK ones and the unicode one; that gives better
  results (that is particularly an issue with cyrillic and greek,
  as CJK fonts have cyrillic and greek chars, but usually
  in doublewidth monospaced glyphs; as a result, sidplay of
  Russian or Greek text in UTF-8 locales for old X11 programs
  is awful). (maybe something similar to #1787)
Comment 1 Pablo Saratxaga 2005-03-08 07:45:32 UTC
Created attachment 2050 [details] [review]
patch the removes some never unused encodings, renames koi8-c -> koi8-k and improves default UTF-8 XLC_LOCALE font list
Comment 2 Pablo Saratxaga 2005-03-08 07:46:52 UTC
*** Bug 708 has been marked as a duplicate of this bug. ***
Comment 3 Hidetoshi Tajima 2005-03-08 08:56:14 UTC
Either lib/XLib or I18N is a component for this?
Comment 4 Roland Mainz 2005-03-08 13:32:54 UTC
Pablo:
Can you make a new diff against Xorg trunk, please ? Some parts touched by the
patch have been heavily changed in X11R6.8.0 ...
Comment 5 Roland Mainz 2005-03-08 13:33:52 UTC
Sorry, I meant s/heavily changed in X11R6.8.0/heavily changed since X11R6.7.0/ ...
Comment 6 Pablo Saratxaga 2005-03-08 13:50:04 UTC
Oh, yes, the paths still said 6.7.0 on the diff,
but the attached patch has been used succesfully
in a 6.8.2 some days ago.

The relevant code has not changed for a long time
(the only one that maybe changed is the en_US.UTF-8
XLC_LOALE file, but note that one has a path of:
xorg-x11-6.8.2/xc/nls/XLC_LOCALE/en_US.UTF-8 )

As for the component... I would say I18N
Comment 7 Roland Mainz 2005-03-09 11:59:10 UTC
Pablo Saratxaga wrote:
> - removes "isiri-3342" and "nokhchi-1" which AFAIK had never
> ever been used.

Any idea who originally added that support (I don't like to remove stuff when
there are still consumers) ?
Comment 8 Roland Mainz 2005-03-09 12:04:09 UTC
ienup:
1. Is the patch OK for you ?
2. Is there a way that you can attach the Solaris 10 version of
xc/nls/XLC_LOCALE/en_US.UTF-8 that we can merge the Solaris fontset config with
the Xorg one, please ?
Comment 9 Pablo Saratxaga 2005-03-09 15:45:09 UTC
It was me that added "isiri-3342" and "nokhchi-1" (and "koi8-k",
and "armscii-8" and a lot more); they can indeed be removed,
they had never been used, and now that unicode is the way
they will never be used, so it is completly useless code.

Maybe "koi8-k" (called "koi8-c" in current Xorg/XFree86 sources)
could be removed too; however that one has been used (for
Tajik, Kirghiz and Uzbek in cyrillic), before using UTF-8.

Comment 10 Ienup Sung 2005-03-09 22:28:28 UTC
Created attachment 2068 [details]
XLC_LOCALE file of Solaris 10 en_US.UTF-8 locale for reference
Comment 11 Ienup Sung 2005-03-09 22:29:08 UTC
Hi Roland, Pablo,

I don't have any opinion on the change of koi8-c or on the removal of isiri-3342
and nokhchi-1. I am also not knowing if we have End of Line or Feature (EOL/EOF)
process in the X.Org. If we have one, it would be nice to follow the process.

Also, even though I also think there shouldn't be a problem, at least sending an
email to xorg mailing list (and perhaps utf-8 mailing list too) announcing the
removal might be an idea before the actual removal to make sure there will be no
surprise by anyone. Also, while we are removing the isiri-3342 and nokhchi-1, as
Pablo also floated, why not also remove the koi8-c/k too?

I also have no objection on the change of en_US.UTF-8/XLC_LOCALE file and I
believe I understand where Pablo is coming from. In fact, using or let people
use full-width Greek and Cyrillic glyphs of Asian fonts wouldn't be really a
good idea considering the primary users of the glyphs are from non-Oriental
countries and regions.

Unfortunately since XLC module implementations and fonts are different and the
XLC_LOCALE definitions are tightly coupled with the XLC module implementation
and also actual fonts and their presentations, I think merging of the two
XLC_LOCALE file definitions would be a bit difficult and time consuming at the
moment. Nonetheless, I attached the current XLC_LOCALE file of Solaris
en_US.UTF-8 at this bug report (S10-en_US.UTF-8-XLC_LOCALE).
Comment 12 Stefan Dirsch 2005-04-25 04:01:36 UTC
*** Bug 3103 has been marked as a duplicate of this bug. ***
Comment 13 Stefan Dirsch 2005-06-16 02:47:11 UTC
After applying the patch legacy apps like xmms X hangs with about 99% cpu load.
When removing the sections for fs/cs 10,11,12,19,21,22,23 in
LC_LOCALE/en_US.UTF-8 (armscii-8, tis-620, tcvn, GBK, BIG5, GEORGIAN-PS,
MULELAO) xmms works again. Looks like appropriate fonts for these encodings
needs to be installed to prevent this problem. IMHO entries should be ignored,
when no appropriate font(s) is/are installed.
Comment 14 Stefan Dirsch 2005-06-16 03:14:13 UTC
Since X.Org does not provide fonts for KOI8-U this section should be removed as
well. I'll attach a patch ASAP. Here is the list of encodings to be removed (IMHO):

koi8-u
armscii-8
tis620-0
TCVN-5712
GBK-0
BIG5-0
GEORGIAN-PS
MULELAO-1
Comment 15 Stefan Dirsch 2005-06-16 09:49:29 UTC
Created attachment 2898 [details] [review]
Proposed patch for cairo-ft-font.c

Removes the mentioned entries for:
- koi8-u 
- armscii-8
- tis-620
- tcvn
- gbk
- big5
- georgian
- laotian
Comment 16 Daniel Stone 2007-02-27 01:25:40 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 17 Stefan Dirsch 2007-11-04 13:03:21 UTC
(In reply to comment #15)
> Created an attachment (id=2898) [details]
> incremental patch for nls/XLC_LOCALE/en_US.UTF-8

This one seems to have been replaced by an unrelated patch.
Comment 18 ojab 2008-02-20 18:12:51 UTC
Created attachment 14467 [details] [review]
patch to give priority to various 8bit encodings (iso8859-*, koi8-{r,u}, tisc620-0,...)  before the CJK ones and the unicode one;

Patch from SuSe (http://ftp.riken.jp/Linux/suse/suse/x86_64/update/9.3/rpm/i586/xorg-x11-libs-6.8.2-30.3.i586.patch.rpm)

I'll be happy to see this patch in X 7.5, because now many fonts/programs cannot be used by, for example, russian people :(.
Comment 19 ojab 2008-02-20 18:15:19 UTC
xorg-git also affected.
Comment 20 Stefan Dirsch 2008-11-22 13:03:29 UTC
SUSE/Novell patch committed now.

commit 418819558d2c60e58b4e3022ce0fadf2143488ac
Author: Stefan Dirsch <sndirsch@suse.de>
Date:   Sat Nov 22 22:01:07 2008 +0100

    Fixed strange font mixups, when fontsets are still used (#2676, Novell #74299).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.