Bug 31291 - Add pkg-config and C include information to GIR
Summary: Add pkg-config and C include information to GIR
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium minor
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 03:18 UTC by Evan Nemerson
Modified: 2010-11-04 11:23 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
add pkg-config and C header information to GIR (824 bytes, patch)
2010-11-01 03:21 UTC, Evan Nemerson
Details | Splinter Review

Description Evan Nemerson 2010-11-01 03:18:59 UTC
The TelepathyGLib-0.12 GIR currently doesn't include information about the pkg-config file or C header, which Vala needs.
Comment 1 Evan Nemerson 2010-11-01 03:21:26 UTC
Created attachment 39948 [details] [review]
add pkg-config and C header information to GIR
Comment 2 Simon McVittie 2010-11-01 04:13:06 UTC
I've applied your patch, thanks. Fixed in git for 0.13.4.

However, if you want to use telepathy-glib from Vala, you should be probably be configuring it with --enable-vala-bindings, which produces and installs telepathy-glib.{vapi,deps} - unless there's some reason not to do that, that I'm not aware of?

(Or, if explicit Vala bindings are no longer necessary and the preferred mechanism is to use the .gir directly, then that's great - let me know which versions of Vala and g-i to recommend, and I can confirm with the authors of libfolks, then delete the .vapi/.deps altogether :-)
Comment 3 Evan Nemerson 2010-11-01 04:42:29 UTC
I'm working on improving Vala's support for GIR. With the patches (almost entirely Luca Bruno's work) that I'm almost ready to push to Vala master and what you just pushed to telepathy-glib you should be able to get rid of those sed invocations in your vala/Makefile.am.

GIR is currently missing some features (see https://bugzilla.gnome.org/show_bug.cgi?id=559704) which will likely prevent it from being the preferred mechanism, at least for a while. That said, telepathy-glib is a bit of a special case since you don't seem to actually use any of those features, so theoretically it will soon be possible to use the GIR directly. Whether you want to is another matter.

Travis Reitter hangs out in #vala, I'll keep him in the loop.
Comment 4 Travis Reitter 2010-11-04 11:23:23 UTC
(In reply to comment #3)
> I'm working on improving Vala's support for GIR. With the patches (almost
> entirely Luca Bruno's work) that I'm almost ready to push to Vala master and
> what you just pushed to telepathy-glib you should be able to get rid of those
> sed invocations in your vala/Makefile.am.

Cutting out this sed hackery is filed as bug 31387.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.