Bug 3593 - The build-env isn't enforcing the correct version of automake
Summary: The build-env isn't enforcing the correct version of automake
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 0.9.3
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
: 4097 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-21 14:15 UTC by Philip Van Hoof
Modified: 2005-08-22 00:14 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch (2.21 KB, patch)
2005-08-21 11:02 UTC, Owen Taylor 		Details | Splinter Review
View All

Description Philip Van Hoof 2005-06-21 14:15:50 UTC 
It's causing the build to fail on most distributions.


src/Makefile.am:78: warning: automake does not support conditional definition of
libcairo_win32_sources in libcairo_la_SOURCES
src/Makefile.am:78: warning: automake does not support conditional definition of
libcairo_win32_sources in libcairo_la_SOURCES
src/Makefile.am:78: warning: automake does not support conditional definition of
libcairo_win32_sources in libcairo_la_SOURCES
src/Makefile.am:78: warning: automake does not support conditional definition of
libcairo_win32_sources in libcairo_la_SOURCES
src/Makefile.am:78: warning: automake does not support conditional definition of
libcairo_win32_sources in libcairo_la_SOURCES
test/Makefile.am:2: TESTS defined both conditionally and unconditionally
test/Makefile.am:102: `check_PROGRAMS' contains configure substitution, but
`EXTRA_PROGRAMS' not defined
test/Makefile.am:170: invalid unused variable name: `xlib_surface_LDADD'
test/Makefile.am:151: invalid unused variable name: `pdf_clip_LDADD'
test/Makefile.am:150: invalid unused variable name: `pdf_surface_LDADD'
test/Makefile.am:152: invalid unused variable name: `ps_surface_LDADD'
doc/public/Makefile.am:3: require version 1.7, but have 1.4-p6
Comment 1 Philip Van Hoof 2005-06-21 14:21:37 UTC 
or document the usage of 

${AUTOMAKE-automake}
${AUTOCONF-autoconf}

On the GNOME development platform it's uncommon to define the required version
of automake and autoconf this way. The autogen.sh has a variable that can be set
if the version of automake/autoconf matters.
Comment 2 Philip Van Hoof 2005-06-21 14:22:38 UTC 
Just to show that there's no such documentation atm

freax@lort:~/cvs/fdo/cairo $ grep AUTOMAKE-automake *
autogen.sh:AUTOMAKE=${AUTOMAKE-automake}
freax@lort:~/cvs/fdo/cairo $

:-)
Comment 3 Owen Taylor 2005-08-18 17:59:11 UTC 
*** Bug 4097 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2005-08-18 18:07:39 UTC 
Does adding the line:

 AUTOMAKE_OPTIONS = 1.7

to the top of cairo/Makefile.am help? I think it may convince the
Debian wrapper script to try using a reasonably recent version of automake.

(Other distributions will generally have automake pointing to the most
recent version.)
Comment 5 Owen Taylor 2005-08-21 11:02:24 UTC 
Created attachment 2964 [details] [review]
Proposed patch
Comment 6 Owen Taylor 2005-08-21 11:24:44 UTC 
Bertram Felgenhauer pointed out that things dont' work if automake-1.10
appears since we are doing numeric comparison on the versions. So, I've
just removed that future proofing.

2005-08-21  Owen Taylor  <otaylor@redhat.com>

        * autogen.sh: Check automake-<ver> if automake isn't sufficiently
        new. (#3593, Philip Van Hoof)
Comment 7 Carl Worth 2005-08-22 17:14:36 UTC 
Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.