Bug 4841 - configure.ac and Pci.h conflicts about PCI_INIT function for x86 FreeBSD
Summary: configure.ac and Pci.h conflicts about PCI_INIT function for x86 FreeBSD
Status: RESOLVED DUPLICATE of bug 5160
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: unspecified
Hardware: Other FreeBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
Depends on:
Blocks: 1690
  Show dependency treegraph
Reported: 2005-10-21 10:29 UTC by Diego Elio Pettenò
Modified: 2005-11-28 15:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

xorg-server-0.99.2-fbsd.patch (501 bytes, patch)
2005-11-02 02:36 UTC, Diego Elio Pettenò
no flags Details | Splinter Review

Description Diego Elio Pettenò 2005-10-21 10:29:55 UTC
Seems like there's a conflict between configure.ac and   
On the header there's this:   
#elif defined(__i386__) || defined(i386)   
# define ARCH_PCI_INIT ix86PciInit   
# define INCLUDE_XF86_MAP_PCI_MEM   
# define INCLUDE_XF86_NO_DOMAIN   
# if defined(linux)   
#  define ARCH_PCI_OS_INIT linuxPciInit   
# endif   
#elif defined(__mc68000__)   
so it tries to use ix86PciInit for FreeBSD (as there's no #if defined for it).  
Bug in configure.ac there's:  
        case $host_os in  
                *linux*)        DEFAULT_INT10=vm86 ;;  
                *freebsd*)      xorg_bus_ix86pci="no"  
                                AC_DEFINE(USE_DEV_IO) ;;  
                *netbsd*)       xorg_bus_ix86pci="no"  
                                AC_DEFINE(USE_I386_IOPL) ;;  
                *openbsd*)      xorg_bus_ix86pci="no"  
                                AC_DEFINE(USE_I386_IOPL) ;;  
that disable ix86pci on FreeBSD, thus ix86Pci.c source file is not compiled,  
thus leading to undefined symbol later in the build process. 
I'm not sure what is the right way to fix this, if it's wrong the configure or 
the source file, but one of the two should be fixed... 
Thanks in advance, 
Comment 1 Diego Elio Pettenò 2005-10-21 11:57:17 UTC
I take this as a bug in configure.ac? 
Comment 2 Diego Elio Pettenò 2005-11-02 02:36:10 UTC
Created attachment 3683 [details] [review]

This patch syncs configure to Pci.h [with the idea that being broken is always
the autotools part], and let xorg-server finally compile.
Comment 3 Diego Elio Pettenò 2005-11-12 08:31:29 UTC
0.99.3 still needs this patch. 
Comment 4 Diego Elio Pettenò 2005-11-29 10:44:25 UTC
Bug #5160 from Eric should also fix this. 

*** This bug has been marked as a duplicate of 5160 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.