Bug 5160 - xfree86 ddx bus selection doesn't match monolithic
Summary: xfree86 ddx bus selection doesn't match monolithic
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: x86 (IA32) FreeBSD
: high normal
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
: 4841 (view as bug list)
Depends on:
Blocks: 1690
  Show dependency treegraph
 
Reported: 2005-11-25 22:09 UTC by Eric Anholt
Modified: 2005-12-02 07:51 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
fix os-support/bus for other OSes/platforms (6.33 KB, patch)
2005-11-25 22:10 UTC, Eric Anholt
ajax: 6.9/7.0+
Details | Splinter Review
configure.ac linuxPci typo fix (803 bytes, patch)
2005-12-02 01:40 UTC, Michel Dänzer
michel: 6.9/7.0?
Details | Splinter Review

Description Eric Anholt 2005-11-25 22:09:12 UTC
I noticed from a build failure on i386 FreeBSD that the xfree86 ddx's
os-specific bus support choices in modular don't match monolithic.  Attached is
a patch that I think gets things matching monolithic (or at least improved) --
not flagging it for 6.9 until I either get some review or get some sleep, but I
think it's worth being a blocker until then.
Comment 1 Eric Anholt 2005-11-25 22:10:29 UTC
Created attachment 3902 [details] [review]
fix os-support/bus for other OSes/platforms
Comment 2 Eric Anholt 2005-11-29 07:45:46 UTC
Comment on attachment 3902 [details] [review]
fix os-support/bus for other OSes/platforms

I think it looks fine, except for removing the first xorg_bus_sparc=no which
should also be done.  Approved?
Comment 3 Diego Elio Pettenò 2005-11-29 10:44:25 UTC
*** Bug 4841 has been marked as a duplicate of this bug. ***
Comment 4 Adam Jackson 2005-11-30 13:39:32 UTC
Comment on attachment 3902 [details] [review]
fix os-support/bus for other OSes/platforms

looks right to me, go ahead
Comment 5 Eric Anholt 2005-12-01 16:00:44 UTC
Committed.
Comment 6 Thomas Winischhofer 2005-12-02 00:24:35 UTC
Now linuxPci.c is no longer built here, which leads to unresolved symbols in -
among others - utils/pcitweak.
Comment 7 Michel Dänzer 2005-12-02 01:40:06 UTC
Created attachment 3962 [details] [review]
configure.ac linuxPci typo fix

Eric, do you know something about the relationship between Linux and BSD that
we don't? ;)
Comment 8 Michel Dänzer 2005-12-02 01:42:07 UTC
Comment on attachment 3962 [details] [review]
configure.ac linuxPci typo fix

Trivial typo fix.
Comment 9 Thomas Winischhofer 2005-12-02 06:06:31 UTC
*lol* (sorry, couldn't resist)
Comment 10 Kevin E. Martin 2005-12-03 02:51:29 UTC
Already fixed in CVS.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.