Bug 49341 - [patch] splash uses cmykTransferC for M, Y and K in two places
Summary: [patch] splash uses cmykTransferC for M, Y and K in two places
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: splash backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-01 08:41 UTC by William Bader
Modified: 2012-05-10 11:03 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
patch against poppler cloned from git on 01May12 (2.08 KB, patch)
2012-05-01 08:41 UTC, William Bader 		Details | Splinter Review
View All

Description William Bader 2012-05-01 08:41:48 UTC 
Created attachment 60853 [details] [review]
patch against poppler cloned from git on 01May12

I noticed two places where splash uses cmykTransferC for all four components.
I don't have a test file that shows a problem, but I suspect that it isn't right.
I have attached a patch to map each component through its corresponding transfer.
William
Comment 1 Albert Astals Cid 2012-05-10 10:33:46 UTC 
Thomas?
Comment 2 Thomas Freitag 2012-05-10 10:47:19 UTC 
(In reply to comment #1)
> Thomas?

Sorry, I hadn't time to look into it. But short look at the review tells me that William obviously is right. Seems that I just made a copy & paste without adjusting every place where it is necessary: only the if case was adjusted, not the else case. Sorry :-(
Comment 3 Albert Astals Cid 2012-05-10 11:03:18 UTC 
Pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.