Bug 51586 - Calc UI: Conditional formatting dialog broken in LO 3.6.0 Beta2
Summary: Calc UI: Conditional formatting dialog broken in LO 3.6.0 Beta2
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.0.0.beta2
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-30 04:16 UTC by Gerry
Modified: 2012-07-16 06:47 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot 1 conditional formatting (126.33 KB, image/png)
2012-06-30 04:16 UTC, Gerry
Details
Screenshot 2 conditional formatting (139.41 KB, image/png)
2012-06-30 04:17 UTC, Gerry
Details
Screenshot 3 conditional formatting (190.25 KB, image/png)
2012-07-03 00:11 UTC, Gerry
Details
Screenshot 4 old conditional formatting dialog (LO 3.4.5) (147.27 KB, image/png)
2012-07-03 00:12 UTC, Gerry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry 2012-06-30 04:16:46 UTC
Created attachment 63636 [details]
Screenshot 1 conditional formatting

The dialog for conditional formatting in LibreOffice Calc 3.6 Beta2 is broken and unusable.

How to reproduce:
* Type in first cell 1, second cell 2 and third cell 3.
* Mark these cells
* Got to "Format"->"Conditional Formatting"->"Conditional Formatting" (BTW: Why is it now hidden in a sub-sub-menu with the same name as the sub-menu?)
* The conditional format dialog which appears is broken. See screenshot 1. Even after clicking on "add" in the dialog, the dialog is still broken. See screenshot 2.

System: Ubuntu 11.10, 64-bit, german local, LibreOffice Version 3.6.0.0.beta2
(Build ID: f010139) installed from the DEB (including German language pack).
Comment 1 Gerry 2012-06-30 04:17:16 UTC
Created attachment 63637 [details]
Screenshot 2 conditional formatting
Comment 2 Jean-Baptiste Faure 2012-07-01 07:56:39 UTC
Yes there is several problems with this new dialog. It is a work in progress, at least until beta-3.
But, please be more specific : add detail on what is broken from your point of view.

Best regards. JBF
Comment 3 Gerry 2012-07-02 13:31:36 UTC
In order to see what is broken, please have a look at the two screenshots 1 and 2:
The conditional format dialog starts completely empty (screenshot 1). Even after clicking on "add" (screenshot 2) it is fundamentally broken. It is not really possible to enter any condition in this dialog nor assign a cell/number format to it.
Comment 4 Jean-Baptiste Faure 2012-07-02 21:16:42 UTC
(In reply to comment #3)
> In order to see what is broken, please have a look at the two screenshots 1 
> and 2:

Of course, but if I ask, it is because these screenshots are not self-explaining for me.
 
> The conditional format dialog starts completely empty (screenshot 1). 

Yes, it is empty when there is no conditional formatting defined in the selected cells.

> Even after clicking on "add" (screenshot 2) it is fundamentally broken. It is 
> not really possible to enter any condition in this dialog nor assign a 
> cell/number format to it.

What do you want to say by "not really possible" ? You can choose in the dropdown lists and type a formula or a value in the condition field.

Best regards. JBF
Comment 5 Gerry 2012-07-03 00:11:26 UTC
Created attachment 63747 [details]
Screenshot 3 conditional formatting
Comment 6 Gerry 2012-07-03 00:12:31 UTC
Created attachment 63748 [details]
Screenshot 4 old conditional formatting dialog (LO 3.4.5)
Comment 7 Gerry 2012-07-03 00:28:17 UTC
I describe the problems with the dialog more in detail. In the list, you find design decisions as well as bugs:

* The new menu entry "Format"->"Conditional Formatting"->"Conditional Formatting" does not make sense to me. Why "Conditional Formatting" nested in a sub-menu of "Conditional Formatting"?
* Why does the dialog start empty when everyone wants to define at least one condition when opening this dialog? (screen shot 1)
* The German translation for "Cancel" is not readible (screen shot 1)
* The German translation of three buttons in screen shot 2 is not readible. Also, the preview window of the style is too small.
* There is no button anymore for "New Style", but it is rather buried in the list of styles. This is IMHO counter-intuitive.
* Generally the previous dialog (screen shot 4) had much better usability. It was absolutely straight forward, whereas the new dialog is not.
* It is not possible to select a cell or cell range as value for the condition. This was possible in the old dialog and it is a MUST.
* When going back to the first dialog (where it is possible to add or delete conditions), the layout is broken and it is not possible to read anything (screen shot 3)
* What is the rationale behind the decision to have two windows for the conditional formatting dialog? Why to have one window where it is only possible to add or delete conditions and another one where one can define a condition. This is IMHO a step back from the old dialog.
Comment 8 Jean-Baptiste Faure 2012-07-03 21:42:37 UTC
Work in progress.
Please, wait until beta-3 and try again. There is a second submenu under Conditional Formatting: "Manage" which allow to list all conditional formatting in a sheet, edit or remove them.

Best regards. JBF
Comment 9 gleppert 2012-07-06 09:04:27 UTC
@Markus: Thanks for looking into this bug. Can you please explain why you declared this bug as RESOLVED -> NOTABUG? IMHO, it is a bug and also not yet resolved.
Comment 10 gleppert 2012-07-07 08:20:25 UTC
Following bug description is still valid in LO 3.6 Beta 3. I deleted/changed my previous description conderning the solved issues and added some new issues to the list. Therefore, I set this bug to REOPENED.

Found issues in Beta 3:

* It is not possible to select a cell or cell range as value for the condition.
This was possible in the old dialog and it is an absolute MUST for the new dialog.
* The new menu entry "Format"->"Conditional Formatting"->"Conditional
Formatting" does not make much sense. Why "Conditional Formatting" nested in a
sub-menu of "Conditional Formatting"? The second dialog should be rather called "Add conditions".
* Why does the dialog start empty when every user wants to define at least one
condition when opening this dialog? (screen shot 1). There should be at least a first condition already visible.
* There is no button anymore for "New Style", but it is rather buried in the
list of styles. This is IMHO counter-intuitive.
* The German translations for "Cancel" and "OK" have typos: "~Abbrechen" and "~OK". Same problem is in the first and the second dialog.
* The German translation "Apply Style" is wrong. It is "Bestätige Vorlage" (and in fact is not fully readible), but should be "Vorlage zuweisen".
* Generally the old dialog (screen shot 4) had much better usability. It
was absolutely straight forward, whereas the new dialog does not seem to improve usability.
* What is the rationale behind the decision to have two windows for the
conditional formatting dialog and another third window for "manage" the conditions? Particularly the first dialog of "Conditional formatting" and the dialog of "Manage" seems to be overlapping. Why is it like that? It seems to be inconsistent.
Comment 11 Markus Mohrhard 2012-07-13 06:48:14 UTC
Create clean bug reports and I will look at them.

Some parts in this bug report are invalid and other ones are already fixed. I won't spend time on trying to separate useful parts from crap and just close this bug report as NOTABUG. If you don't like it you may change it to WONTFIX or INVALID.
Comment 12 Gerry 2012-07-13 15:06:56 UTC
@Markus: Thank you for your reply. 

I will create a new bug entry, but let me ask three questions:

1. Please tell me what was not "clean" in this bug report?
2. What parts in this bug report are invalid?
3. Comment 10 clearly lays out the current state of the bug in LO 3.6 Beta 3, what else do you need?
Comment 13 Gerry 2012-07-14 07:02:41 UTC
New bug 52073 opened.

@Markus: BTW, please never ever imagine to call anything from a voluntary contributor "crap"
Comment 14 Markus Mohrhard 2012-07-16 02:36:37 UTC
(In reply to comment #13)
> New bug 52073 opened.
> 
> @Markus: BTW, please never ever imagine to call anything from a voluntary
> contributor "crap"

I'm a voluntary contributor myself and as long as you use sentences like "This was possible in the old dialog and it is an absolute MUST for the new
dialog." I'm not taking your bug reports serious.

You're around 2 to 4 months too late, the discussiona round this dialog has been done some months ago and I will not change it for 3-6 anymore than fixing serious bugs.
Comment 15 Gerry 2012-07-16 06:47:59 UTC
@Markus: I apologize, in case my wording was too harsh. This wasn't intended. Sorry. 

In this regard (the bullet point with the "MUST"), the new dialog has in fact a major regression: 

The regression is not a design issue, but it is a loss of functionality. In the old dialog it was possible to click into the field where you can enter the conditions, then you could select/pick a cell or cell range with the mouse as value for the condition. This feature is lost in the new dialog. Now I must manually type in e.g. "$Sheet1.$H$17:$H$19", before I could "pick" it.