Bug 65024 - [hsw] eDP can't display on Hsw-ULT in UEFI mode -- requires 24bpp bw calculation for 18bpp pipe
Summary: [hsw] eDP can't display on Hsw-ULT in UEFI mode -- requires 24bpp bw calculat...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 06:41 UTC by XiongZhang
Modified: 2017-07-24 22:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg that eDP can't display (140.35 KB, text/plain)
2013-05-27 07:05 UTC, XiongZhang
no flags Details
dmesg that eDP can display correctly (195.68 KB, text/plain)
2013-05-28 03:33 UTC, XiongZhang
no flags Details
intel_reg_dump that eDP can't display (10.03 KB, text/plain)
2013-05-28 03:34 UTC, XiongZhang
no flags Details
intel_reg_dump that eDP can display correctly (10.03 KB, text/plain)
2013-05-28 03:35 UTC, XiongZhang
no flags Details

Description XiongZhang 2013-05-27 06:41:09 UTC

    
Comment 1 XiongZhang 2013-05-27 06:48:50 UTC
platform:
SharkBay-ULT:
BIOS: HSWLPTU1.86C.114.R07
CPU: Pre-release Intel MCP processor code named Hasswell M,(2+2) 2 cores,GT2,C0 Chipset :Lynx Point-LP A0(QDBY)
Baseboard: Intel ULT board code named Whitetip Mountain Fab 3.
Kernel: drm-intel-next-queued
OS: Ubuntu 13.04

step to reproduce:
1. set "csm always off " in bios
2. boot drm-intel-next-queued kernel in UEFI native mode
3. after i915 modle load and run
4. the eDP display is black, can't show anything. System is still running and I can login in through SSH.
Comment 2 XiongZhang 2013-05-27 07:05:06 UTC
Created attachment 79828 [details]
dmesg that eDP can't display
Comment 3 XiongZhang 2013-05-27 07:48:18 UTC
The issue seems relate to dp link bandwidth. If I add following patch, eDP can display correctly.
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 3426a61..2d26f8f 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -724,6 +724,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
        bpp = min_t(int, 8*3, pipe_config->pipe_bpp);
        if (is_edp(intel_dp) && dev_priv->vbt.edp_bpp)
                bpp = min_t(int, bpp, dev_priv->vbt.edp_bpp);
+
+       bpp = 24;

        for (; bpp >= 6*3; bpp -= 2*3) {
                mode_rate = intel_dp_link_required(target_clock, bpp);
@@ -744,6 +746,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
        return false;

 found:
+       bpp = 18;
+
        if (intel_dp->color_range_auto) {

Bios report dev_priv->vbt.edp_bpp=18.
Comment 4 Chris Wilson 2013-05-27 13:24:54 UTC
The effect of that hack would be to increase the number of lanes used or increase the frequency. It would be useful to attach the dmesg from the working configuration so that we can compare.
Comment 5 Daniel Vetter 2013-05-27 17:18:49 UTC
Iirc Paulo has a similarly unhappy eDP panel which wants the higher clock ...
Comment 6 XiongZhang 2013-05-28 03:33:17 UTC
Created attachment 79876 [details]
dmesg that eDP can display correctly
Comment 7 XiongZhang 2013-05-28 03:34:20 UTC
Created attachment 79877 [details]
intel_reg_dump that eDP can't display
Comment 8 XiongZhang 2013-05-28 03:35:04 UTC
Created attachment 79878 [details]
intel_reg_dump that eDP can display correctly
Comment 9 Paulo Zanoni 2013-06-05 18:04:18 UTC
I updated by BIOS and for some reason the VBT is not saying it supports 18bpp (even though the BIOS is configured to boot with 18bpp). Not a big problem since this is a development machine.

But if I force vbt.bpp to 18 I get a black screen when booting.
Comment 10 Jani Nikula 2013-09-10 09:45:01 UTC
We now have bug 67950, https://bugzilla.kernel.org/show_bug.cgi?id=59841 and
https://bugzilla.kernel.org/show_bug.cgi?id=60881 with presumably the same issue too.
Comment 11 Paulo Zanoni 2013-12-05 12:58:30 UTC
Does this still happen in current drm-intel-nightly? We have added some workarounds since then.
Comment 12 Jani Nikula 2013-12-05 15:10:31 UTC
commit 1021442098ee9328fdd4d113d63a3a7f2f40c37b
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Nov 18 07:38:16 2013 +0100

    drm/i915: Replicate BIOS eDP bpp clamping hack for hsw

and bug 71049.
Comment 13 Daniel Vetter 2013-12-05 19:43:31 UTC
Yeah, this should be fixed now, please reopen if this is not the case.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.