Bug 69102 - Enable compiler warnings by default
Summary: Enable compiler warnings by default
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-08 15:39 UTC by Kalev Lember
Modified: 2013-09-09 15:04 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Add missing static keywords to internal functions (1.67 KB, patch)
2013-09-08 15:44 UTC, Kalev Lember
Details | Splinter Review
Enable compiler warnings by default (1.73 KB, patch)
2013-09-08 15:45 UTC, Kalev Lember
Details | Splinter Review
Avoid the dependency on gnome-common (5.74 KB, patch)
2013-09-08 15:45 UTC, Kalev Lember
Details | Splinter Review
Minor pkgconfig file cleanup (975 bytes, patch)
2013-09-08 15:46 UTC, Kalev Lember
Details | Splinter Review
Update .gitignore (588 bytes, patch)
2013-09-08 15:46 UTC, Kalev Lember
Details | Splinter Review
Fix distcheck (688 bytes, patch)
2013-09-08 15:47 UTC, Kalev Lember
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2013-09-08 15:39:39 UTC
I fixed up all the -Wall compiler warnings last week (one of these was an actual crasher), but some new ones have snuck in since then. We should make sure the warnings show up by default, otherwise it will be continuous catching up.
Comment 1 Kalev Lember 2013-09-08 15:44:43 UTC
Created attachment 85429 [details] [review]
Add missing static keywords to internal functions
Comment 2 Kalev Lember 2013-09-08 15:45:22 UTC
Created attachment 85430 [details] [review]
Enable compiler warnings by default

Drop the --enable-strict-cc configure option and replace it with
--enable-compile-warnings from gnome-common. This is enabled by default
to make sure warnings show up during development.
Comment 3 Kalev Lember 2013-09-08 15:45:48 UTC
Created attachment 85431 [details] [review]
Avoid the dependency on gnome-common

Ship gnome-compiler-flags.m4 in m4/ so that we wouldn't need the whole
gnome-common during build time.
Comment 4 Kalev Lember 2013-09-08 15:46:23 UTC
Created attachment 85432 [details] [review]
Minor pkgconfig file cleanup

Drop the Requires: as we don't ship a shared library, and add
datarootdir to stop autotools from complaining.
Comment 5 Kalev Lember 2013-09-08 15:46:39 UTC
Created attachment 85433 [details] [review]
Update .gitignore
Comment 6 Kalev Lember 2013-09-08 15:47:03 UTC
Created attachment 85435 [details] [review]
Fix distcheck

Dist org.freedesktop.GeoClue2.service.in so that it gets included in
tarballs.
Comment 7 Zeeshan Ali 2013-09-09 14:24:23 UTC
Comment on attachment 85429 [details] [review]
Add missing static keywords to internal functions

Review of attachment 85429 [details] [review]:
-----------------------------------------------------------------

ACK
Comment 8 Zeeshan Ali 2013-09-09 14:35:42 UTC
Comment on attachment 85430 [details] [review]
Enable compiler warnings by default

Review of attachment 85430 [details] [review]:
-----------------------------------------------------------------

ACK
Comment 9 Zeeshan Ali 2013-09-09 14:38:03 UTC
Comment on attachment 85431 [details] [review]
Avoid the dependency on gnome-common

Review of attachment 85431 [details] [review]:
-----------------------------------------------------------------

ACK
Comment 10 Zeeshan Ali 2013-09-09 14:43:11 UTC
Comment on attachment 85432 [details] [review]
Minor pkgconfig file cleanup

Review of attachment 85432 [details] [review]:
-----------------------------------------------------------------

ack
Comment 11 Zeeshan Ali 2013-09-09 14:52:53 UTC
Comment on attachment 85433 [details] [review]
Update .gitignore

Review of attachment 85433 [details] [review]:
-----------------------------------------------------------------

ack
Comment 12 Zeeshan Ali 2013-09-09 14:53:42 UTC
Comment on attachment 85435 [details] [review]
Fix distcheck

Review of attachment 85435 [details] [review]:
-----------------------------------------------------------------

ack
Comment 13 Zeeshan Ali 2013-09-09 15:04:28 UTC
All pushed!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.