I fixed up all the -Wall compiler warnings last week (one of these was an actual crasher), but some new ones have snuck in since then. We should make sure the warnings show up by default, otherwise it will be continuous catching up.
Created attachment 85429 [details] [review] Add missing static keywords to internal functions
Created attachment 85430 [details] [review] Enable compiler warnings by default Drop the --enable-strict-cc configure option and replace it with --enable-compile-warnings from gnome-common. This is enabled by default to make sure warnings show up during development.
Created attachment 85431 [details] [review] Avoid the dependency on gnome-common Ship gnome-compiler-flags.m4 in m4/ so that we wouldn't need the whole gnome-common during build time.
Created attachment 85432 [details] [review] Minor pkgconfig file cleanup Drop the Requires: as we don't ship a shared library, and add datarootdir to stop autotools from complaining.
Created attachment 85433 [details] [review] Update .gitignore
Created attachment 85435 [details] [review] Fix distcheck Dist org.freedesktop.GeoClue2.service.in so that it gets included in tarballs.
Comment on attachment 85429 [details] [review] Add missing static keywords to internal functions Review of attachment 85429 [details] [review]: ----------------------------------------------------------------- ACK
Comment on attachment 85430 [details] [review] Enable compiler warnings by default Review of attachment 85430 [details] [review]: ----------------------------------------------------------------- ACK
Comment on attachment 85431 [details] [review] Avoid the dependency on gnome-common Review of attachment 85431 [details] [review]: ----------------------------------------------------------------- ACK
Comment on attachment 85432 [details] [review] Minor pkgconfig file cleanup Review of attachment 85432 [details] [review]: ----------------------------------------------------------------- ack
Comment on attachment 85433 [details] [review] Update .gitignore Review of attachment 85433 [details] [review]: ----------------------------------------------------------------- ack
Comment on attachment 85435 [details] [review] Fix distcheck Review of attachment 85435 [details] [review]: ----------------------------------------------------------------- ack
All pushed!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.