Stop testing deprecated stuff. That will make porting to next much easier.
Branch: http://cgit.collabora.com/git/user/xclaesse/telepathy-salut.git/log/?h=misc It depends on bug #69625
Note that salut crash sometimes in some tests. The crash happens in libdbus, at least with the version in ubuntu (1.6.8-1ubuntu6.1) but they seems to all pass reliably with libdbus master.
(In reply to comment #2) > Note that salut crash sometimes in some tests. The crash happens in libdbus, > at least with the version in ubuntu (1.6.8-1ubuntu6.1) but they seems to all > pass reliably with libdbus master. If this is your backtrace (copying it from pastebin.com so it won't expire): #5 0x00002aaaac09e31d in ?? () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #6 0x00002aaaac088fc4 in ?? () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #7 0x00002aaaac08a36d in ?? () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #8 0x00002aaaac08976c in dbus_connection_send_with_reply_and_block () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #9 0x00002aaaac084e4c in dbus_bus_register () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #10 0x00002aaaac08510f in ?? () from /lib/x86_64-linux-gnu/libdbus-1.so.3 #11 0x00002aaab1a6d8ac in ?? () from /usr/lib/x86_64-linux-gnu/libproxy/0.4.11/modules/network_networkmanager.so #12 0x00002aaab144b299 in libproxy::proxy_factory::check_network_topology (this=this@entry=0x17dbcf0) at /build/buildd/libproxy-0.4.11/libproxy/proxy.cpp:242 #13 0x00002aaab144d09a in libproxy::proxy_factory::get_proxies (this=this@entry=0x17dbcf0, realurl=...) at /build/buildd/libproxy-0.4.11/libproxy/proxy.cpp:205 #14 0x00002aaab144d59d in px_proxy_factory_get_proxies (self=0x17dbcf0, url=url@entry=0x17c6ab0 "none://127.0.0.1:45516") at /build/buildd/libproxy-0.4.11/libproxy/proxy.cpp:463 #15 0x00002aaab123c1fe in get_libproxy_proxies (resolver=0x17da980, uri=0x17c6ab0 "none://127.0.0.1:45516", cancellable=<optimized out>, error=error@entry=0x2aaab1e6fd38) at glibproxyresolver.c:146 #16 0x00002aaab123c284 in _lookup_async (task=0x1786450, object=<optimized out>, task_data=<optimized out>, cancellable=<optimized out>) at glibproxyresolver.c:198 #17 0x00002aaaac33d835 in g_task_thread_pool_thread (thread_data=0x1786450, pool_data=<optimized out>) at /build/buildd/glib2.0-2.36.0/./gio/gtask.c:1242 #18 0x00002aaaac8d56f2 in g_thread_pool_thread_proxy (data=<optimized out>) at /build/buildd/glib2.0-2.36.0/./glib/gthreadpool.c:309 #19 0x00002aaaac8d4eb5 in g_thread_proxy (data=0x2aaab4006d90) at /build/buildd/glib2.0-2.36.0/./glib/gthread.c:798 #20 0x00002aaaacf9ef8e in start_thread (arg=0x2aaab1e70700) at pthread_create.c:311 then it's probably Bug #54972, which is fixed in libdbus master. Workaround: Bug #65296. I've just pushed the same commit to Salut.
> Drop 1-1 Tubes unit tests I think this deserves an explanation in the long commit message, like "These tubes are disabled until we get a better network protocol for them, and their tests have been disabled since 20xy." (with the right year).
Everything else in this branch looks fine. Insta-r+ with the commit-message change I suggested.
(In reply to comment #5) > Insta-r+ with the commit-message > change I suggested. ... er, once we have a telepathy-glib release against which it can compile :-)
(In reply to comment #6) > once we have a telepathy-glib release against which it can compile That was 0.21.2.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.