> - IMPLEMENT (get_alias_flags);

Is the replacement property implemented?

> - TpHandleRepoIface *repos[NUM_TP_HANDLE_TYPES])
> + TpHandleRepoIface *repos[TP_NUM_HANDLE_TYPES])

Please sed this in master

> + "message", G_TYPE_STRING, message,

This is going to crash if message is null, please copy the updated shim from wherever Guillaume committed it (Idle? tp-glib?) or double-check that message is never null

> -#define SALUT_PROTOCOL_LOCAL_XMPP_ICON_NAME "im-" SALUT_PROTOCOL_LOCAL_XMPP_NAME
> +#define SALUT_PROTOCOL_LOCAL_XMPP_ICON_NAME "im-local-xmpp"

Ugh, that hadn't occurred to me. We should probably change TpProtocol in next so it applies s/_/-/ when deriving the default icon name? :-(

> +++ b/tests/twisted/constants.py

Please sync this from Gabble on master, so it uses PREFIX more and the resulting diff is less horrible.

(In reply to comment #1)
> > - IMPLEMENT (get_alias_flags);
> 
> Is the replacement property implemented?

Still needs doing?

> > - TpHandleRepoIface *repos[NUM_TP_HANDLE_TYPES])
> > + TpHandleRepoIface *repos[TP_NUM_HANDLE_TYPES])
> 
> Please sed this in master

done

> > + "message", G_TYPE_STRING, message,
> 
> This is going to crash if message is null, please copy the updated shim from
> wherever Guillaume committed it (Idle? tp-glib?) or double-check that
> message is never null

Still needs doing?

> Ugh, that hadn't occurred to me. We should probably change TpProtocol in
> next so it applies s/_/-/ when deriving the default icon name? :-(

done

> > +++ b/tests/twisted/constants.py
> 
> Please sync this from Gabble on master, so it uses PREFIX more and the
> resulting diff is less horrible.

done

All done now, 'next' branch pushed.