Bug 72264 - GLSL error reporting
GLSL error reporting
Product: Mesa
Classification: Unclassified
Component: glsl-compiler
Other All
: low enhancement
Assigned To: Intel 3D Bugs Mailing List
Intel 3D Bugs Mailing List
Depends on:
  Show dependency treegraph
Reported: 2013-12-03 13:02 UTC by Kevin Rogovin
Modified: 2014-05-21 02:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Shader with GLSL messages appended. (1.24 KB, text/plain)
2013-12-03 13:02 UTC, Kevin Rogovin
patch, so tiny it is (1.01 KB, text/plain)
2013-12-05 17:54 UTC, Kevin Rogovin

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Rogovin 2013-12-03 13:02:09 UTC
Created attachment 90154 [details]
Shader with GLSL messages appended.

When a function is encountered that is not defined, the warning message gives the line and column number as 0 instead of the location of the invalid invocation.
Comment 1 Kenneth Graunke 2013-12-03 19:39:18 UTC
Yep, that's a known bug.  The YYLLOC information is not getting propagated through from the parser correctly in this case.

Shouldn't be too hard to fix, but nobody's had time to look into it.

Kevin, would you like to take a look?
Comment 2 Kevin Rogovin 2013-12-05 17:54:02 UTC
Created attachment 90319 [details]
patch, so tiny it is
Comment 3 Kevin Rogovin 2013-12-05 17:55:21 UTC
if nothing wwnt wrong it should find its way on mesa-dev.
Comment 4 Ian Romanick 2013-12-05 19:14:18 UTC
(In reply to comment #3)
> if nothing wwnt wrong it should find its way on mesa-dev.

I think something went wrong.  Did you use git-send-email?  That is the only accepted way to send patches out for review.

Also, if you're going to work on a bug, you should assign it to yourself and change the status to ASSIGNED.
Comment 5 Matt Turner 2014-05-21 02:19:17 UTC
I don't know what happened to Kevin's patch, or if he ever sent it, but Sir Anthony fixed this with five or six patches back in February.