Bug 73585 - plymouth with option --wait does not unlock the termios structure
Summary: plymouth with option --wait does not unlock the termios structure
Status: RESOLVED MOVED
Alias: None
Product: plymouth
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
Keywords:
: 66260 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-14 04:04 UTC by Raymond Wooninck
Modified: 2018-08-07 09:24 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix boot_vga problem with framebuffer devices (961 bytes, patch)
2014-12-08 14:23 UTC, Matthias Klumpp
Details | Splinter Review

Description Raymond Wooninck 2014-01-14 04:04:54 UTC
plymouth with option --wait does not unlock the termios structure of the physical devices used for /dev/console aka the system console.  

Currently systemd uses the plymouth-quit-wait.service with

 [Service]
 ExecStart=-/usr/bin/plymouth --wait
 Type=oneshot
 TimeoutSec=20
 [Install]
 WantedBy=multi-user.target

which is required by serial-getty@.service but it seems not to work.
Comment 1 David Lechner 2014-08-06 01:34:43 UTC
I was running into this bug as well as some others. After reading over bug 80553 comment 8, I patched ply-device-manager.c so that it does not call device_is_for_local_console() and always assigns a terminal. Once I did that, this is no longer an issue.

So, I think it is safe to say that the root cause of this bug is plymouth not having a terminal assigned to the seat that it uses.
Comment 2 David Lechner 2014-08-06 01:35:04 UTC
*** Bug 66260 has been marked as a duplicate of this bug. ***
Comment 3 Matthias Klumpp 2014-12-08 14:23:28 UTC
Created attachment 110567 [details] [review]
Fix boot_vga problem with framebuffer devices
Comment 4 Matthias Klumpp 2014-12-08 14:26:23 UTC
Hi!
We also ran into that bug recently at Tanglu, and the attached patch fixes this issue by detecting VGA framebuffers correctly.
The same patch is applied by OpenSUSE as well, the original author seems to be Stephan Kulow (per OpenSUSE change history).
Maybe this is something to be considered for upstream inclusion?
Cheers,
    Matthias
Comment 5 Ray Strode [halfline] 2014-12-08 16:25:07 UTC
that patch isn't going to work as it, because it's going to make devices that aren't being used, show up as being for the local console (will break optimus, multi-seat, etc)  I agree this issue is serious and needs to be fixed soon, though.
Comment 6 Matthias Klumpp 2014-12-10 15:21:04 UTC
Ah, thanks for(In reply to Ray Strode [halfline] from comment #5)
> that patch isn't going to work as it, because it's going to make devices
> that aren't being used, show up as being for the local console (will break
> optimus, multi-seat, etc)  I agree this issue is serious and needs to be
> fixed soon, though.

Ah, thanks for that information - it's could to know that we fixed a problem by creating new problems for different users :-/
Unfortunately, I lack the knowledge to correctly fix this problem for all users, but if there's anything I can help with, just tell me.
Cheers,
    Matthias
Comment 7 GitLab Migration User 2018-08-07 09:24:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/plymouth/plymouth/issues/8.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.