Bug 73587 - xserver-60014a4a (git) fails to build (bisected)
Summary: xserver-60014a4a (git) fails to build (bisected)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Keith Packard
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 73654 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-14 06:45 UTC by Jos van Wolput
Modified: 2014-01-23 02:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Jos van Wolput 2014-01-14 06:45:13 UTC 
xserver-60014a4a98ff924ae7f6840781f768c1cc93bbab,
Replace 'pointer' type with 'void *',committer	Keith Packard, 2014-01-12 18:24:11 (GMT)
fails to build (bisected):
-----
make

In file included from ../include/misc.h:78:0,
                 from atom.c:55:
/usr/include/X11/Xdefs.h:105:10: error: expected ')' before 'OSTimePtr'
          OSTimePtr /* pTimeout */,
          ^
In file included from atom.c:57:0:
../include/dix.h:224:54: error: expected ')' before 'WakeupHandlerProcPtr'
                                                      WakeupHandlerProcPtr
                                                      ^
../include/dix.h:230:52: error: expected ')' before 'WakeupHandlerProcPtr'
                                                    WakeupHandlerProcPtr
                                                    ^
atom.c: In function 'MakeAtom':
atom.c:126:26: warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual]
                     free((char *) nd->string);
                          ^
atom.c: In function 'FreeAtom':
atom.c:181:14: warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual]
         free((char *) patom->string);
              ^
make[2]: *** [atom.lo] Error 1
make[2]: Leaving directory `/home/jos/src/xorg/xserver-60014a4a98ff924ae7f6840781f768c1cc93bbab/dix'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/jos/src/xorg/xserver-60014a4a98ff924ae7f6840781f768c1cc93bbab/dix'
make: *** [all-recursive] Error 1
-----
Comment 1 Alan Coopersmith 2014-01-14 07:47:56 UTC 
http://patchwork.freedesktop.org/patch/17893/
Comment 2 Jos van Wolput 2014-01-15 04:47:56 UTC 
(In reply to comment #1)
> http://patchwork.freedesktop.org/patch/17893/

After applying your partch, still get build errors like this one:
/usr/include/X11/fonts/fontproto.h:77:9: error: unknown type name 'pointer'
         pointer        /* ptr */);

I guess all proto files first need to be cleaned up of 'pointer' typedef.
Comment 3 Alan Coopersmith 2014-01-15 08:35:29 UTC 
*** Bug 73654 has been marked as a duplicate of this bug. ***
Comment 4 Keith Packard 2014-01-15 23:18:20 UTC 
Patch to x11proto pushed to master.
Comment 5 lu hua 2014-01-16 02:05:07 UTC 
bug 73587<https://bugs.freedesktop.org/show_bug.cgi?id=73587>

From: bugzilla-daemon@freedesktop.org [mailto:bugzilla-daemon@freedesktop.org]
Sent: Thursday, January 16, 2014 7:18 AM
To: Lu, HuaX
Subject: [Bug 73587] xserver-60014a4a (git) fails to build (bisected)

Keith Packard<mailto:keithp@keithp.com> changed bug 73587<https://bugs.freedesktop.org/show_bug.cgi?id=73587>
What

Removed

Added

Status

ASSIGNED

RESOLVED

Resolution

---

FIXED

Comment # 4<https://bugs.freedesktop.org/show_bug.cgi?id=73587#c4> on bug 73587<https://bugs.freedesktop.org/show_bug.cgi?id=73587> from Keith Packard<mailto:keithp@keithp.com>

Patch to x11proto pushed to master.

________________________________
You are receiving this mail because:

  *   You are on the CC list for the bug.
Comment 6 lu hua 2014-01-16 02:11:04 UTC 
Lu, HuaX would like to recall the message, "[Bug 73587] xserver-60014a4a (git) fails to build (bisected)".
Comment 7 Jos van Wolput 2014-01-16 04:00:09 UTC 
Not yet fixed, this bug should be reopened.
Proto file fontsproto needs to be patched:

In file included from ../include/dixfont.h:30:0,
                 from ../include/dixfontstr.h:28,
                 from cursor.c:57:
/usr/include/X11/fonts/fontstruct.h:125:5: error: unknown type name 'pointer'
     pointer     svrPrivate;

/usr/include/X11/fonts/fontproto.h:77:9: error: unknown type name 'pointer'
         pointer        /* ptr */);
Comment 8 Jos van Wolput 2014-01-23 02:41:25 UTC 
fixed, fontsproto patched, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.