Bug 73654 - [Bisected]Xserver build fails with dix.h:224:54: error: expected ')' before 'WakeupHandlerProcPtr'
Summary: [Bisected]Xserver build fails with dix.h:224:54: error: expected ')' before '...
Status: VERIFIED DUPLICATE of bug 73587
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Keith Packard
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 08:31 UTC by lu hua
Modified: 2014-01-24 01:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2014-01-15 08:31:20 UTC
System Environment:
--------------------------
Xserver         (master)2d2d49dab5c5718989de97d7227aac793479745e

Bug detailed description:
---------------------------
Build master branch Xserver, It fails with following error:

make[2]: Entering directory `/GFX/build/component/Xorg/xorg/xserver/dix'
  CC       atom.lo
In file included from ../include/misc.h:78:0,
                 from atom.c:55:
/opt/X11R7/include/X11/Xdefs.h:105:10: error: expected ')' before 'OSTimePtr'
          OSTimePtr /* pTimeout */,
          ^
In file included from atom.c:57:0:
../include/dix.h:224:54: error: expected ')' before 'WakeupHandlerProcPtr'
                                                      WakeupHandlerProcPtr
                                                      ^
../include/dix.h:230:52: error: expected ')' before 'WakeupHandlerProcPtr'
                                                    WakeupHandlerProcPtr
                                                    ^
make[2]: *** [atom.lo] Error 1
make[2]: Leaving directory `/GFX/build/component/Xorg/xorg/xserver/dix'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/GFX/build/component/Xorg/xorg/xserver/dix'
make: *** [all-recursive] Error 1


Bisect shows: 60014a4a98ff924ae7f6840781f768c1cc93bbab is the first bad commit.
commit 60014a4a98ff924ae7f6840781f768c1cc93bbab
Author:     Keith Packard <keithp@keithp.com>
AuthorDate: Sun Dec 15 01:05:51 2013 -0800
Commit:     Keith Packard <keithp@keithp.com>
CommitDate: Sun Jan 12 10:24:11 2014 -0800

    Replace 'pointer' type with 'void *'

    This lets us stop using the 'pointer' typedef in Xdefs.h as 'pointer'
    is used throughout the X server for other things, and having duplicate
    names generates compiler warnings.

    Signed-off-by: Keith Packard <keithp@keithp.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
Comment 1 Alan Coopersmith 2014-01-15 08:35:29 UTC
Keith pushed the xserver change before the x11proto change.

*** This bug has been marked as a duplicate of bug 73587 ***
Comment 2 lu hua 2014-01-24 01:27:18 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.