8415 – FONTCONFIG_CFLAGS not injected

Bug 8415 - FONTCONFIG_CFLAGS not injected

Summary: FONTCONFIG_CFLAGS not injected

Status:	RESOLVED FIXED

Alias:	None

Product:	poppler
Classification:	Unclassified
Component:	general (show other bugs)
Version:	unspecified
Hardware:	x86 (IA32) Linux (All)

Importance:	high normal
Assignee:	poppler-bugs
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (2):	8820 9055 (view as bug list)
Depends on:
Blocks:

Reported:	2006-09-25 05:35 UTC by morfoh
Modified:	2006-11-16 13:44 UTC (History)
CC List:	2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch for including $(FONTCONFIG_CFLAGS) (2.14 KB, patch) 2006-09-25 05:38 UTC, morfoh	Details \| Splinter Review
Patch for including $(FONTCONFIG_CFLAGS) and $(FONTCONFIG_LIBS) (2.50 KB, patch) 2006-09-25 06:09 UTC, morfoh	Details \| Splinter Review
Show Obsolete (1) View All

Description morfoh 2006-09-25 05:35:46 UTC

While trying to build poppler-0.5.4 I discovered several failures because
'fontcofig/fontconfig.h' was not found.

Example:
------------------------------------------------------------------------------
In file included from pdffonts.cc:19:
../poppler/GlobalParams.h:18:35: error: fontconfig/fontconfig.h: No such file or
directory
../poppler/GlobalParams.h:323: error: ISO C++ forbids declaration of 'FcConfig'
with no type
../poppler/GlobalParams.h:323: error: expected ';' before '*' token
------------------------------------------------------------------------------

I fixed that through appending $(FONTCONFIG_CFLAGS) to the INCLUDES variable of
several Makefile.in files.

Comment 1 morfoh 2006-09-25 05:38:27 UTC

Created attachment 7147 [details] [review]
Patch for including $(FONTCONFIG_CFLAGS)

Comment 2 morfoh 2006-09-25 06:07:37 UTC

Comment on attachment 7147 [details] [review]
Patch for including $(FONTCONFIG_CFLAGS)

patching the Makefile.in files was not correct

Comment 3 morfoh 2006-09-25 06:09:26 UTC

Created attachment 7148 [details] [review]
Patch for including $(FONTCONFIG_CFLAGS) and $(FONTCONFIG_LIBS)

this patch adds $(FONTCONFIG_CFLAGS) and $(FONTCONFIG_LIBS) to some Makefile.in
files

Comment 4 Albert Astals Cid 2006-09-25 13:38:54 UTC

Thanks. Fixed now.

Comment 5 Albert Astals Cid 2006-10-30 10:34:34 UTC

*** Bug 8820 has been marked as a duplicate of this bug. ***

Comment 6 Albert Astals Cid 2006-11-16 13:44:29 UTC

*** Bug 9055 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.