Bug 89870 - [SNB+]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimple fails
Summary: [SNB+]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimp...
Status: CLOSED DUPLICATE of bug 80248
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: Other All
: high major
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 07:22 UTC by shuo.wang
Modified: 2015-04-15 02:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for mesa which is used to fix this issue (1.17 KB, patch)
2015-04-02 07:33 UTC, shuo.wang
Details | Splinter Review

Description shuo.wang 2015-04-02 07:22:16 UTC
System Environment:
--------------------------
Platform: HSW
Libdrm:		(master)libdrm-2.4.60-18-gbc6b5174d362a01f6d638a4db6aaf2fd355db69c
Mesa:		(master)ff87ae1e003be7104d3550250af3343c01cea882
Xserver:	(server-1.17-branch)xorg-server-1.17.1
Xf86_video_intel:(master)2.99.917-219-g745c21fb1aa1fcd54e9a9aeaa7fe6877af39f2f1
Libva:		(master)5ba1a9935ba2b16943f3cc1aaf37c0e561497e51
Libva_intel_driver:	(master)28fab5dc32fac16218f71eb288758e56b980fcd7
Kernel:   4.0.0-rc6_drm-intel-fixes_ee73c6_20150331+

Bug detailed description:
---------------------------
It fails on SNB+ platforms with mesa master branch

output:
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'X11'

Test case 'ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimple'..
#+ GL_RGBA pixel=0x000000FF does not match expected=0x00FF00FF
#+ TestSimple Valid error: GL_NO_ERROR  Actual error: GL_INVALID_OPERATION

  Fail (Fail)

DONE!

Test run totals:
  Passed:        0/1 (0.00%)
  Failed:        1/1 (100.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)

Reproduce steps:
-------------------------
1. xinit
2. ./glcts --deqp-case=ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimple
Comment 1 shuo.wang 2015-04-02 07:33:29 UTC
Created attachment 114824 [details] [review]
Patch for mesa which is used to fix this issue

glEGLImageTargetTexture2DOES(enum target, eglImageOES image) is used to setup texture. And the target should be GL_TEXTURE_EXTERNAL_OES, image should be the handle of a valid EGLImage resource, cast into the type eglImageOES.(https://www.khronos.org/registry/gles/extensions/OES/OES_EGL_image_external.txt)
The test case have already followed the spec.
But in mesa, there is a token image->dma_buf_imported which is used as judgement of glEGLImageTargetTexture2DOES. The default value of this variable is false, and never changed during eglCreateImageKHR which is used to generate image.
So I think maybe the token image->dma_buf_imported should not be the judgement of glEGLImageTargetTexture2DOES, or we need update it in eglCreateImageKHR.
Comment 2 shuo.wang 2015-04-02 08:32:37 UTC
ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestTargetTextureValid is also failed by ./glcts --deqp-case=ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestTargetTextureValid:

Output:
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'X11'

Test case 'ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestTargetTextureValid'..
#+ TestTargetTexture Valid error: GL_NO_ERROR  Actual error: GL_INVALID_OPERATION

  Fail (Fail)

DONE!

Test run totals:
  Passed:        0/1 (0.00%)
  Failed:        1/1 (100.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)


The same root cause, and also fixed by attachment 114824 [details] [review]
Comment 3 shuo.wang 2015-04-08 00:28:57 UTC
Update the bug as a high priority since esconform should all pass.
Comment 4 Matt Turner 2015-04-08 00:40:07 UTC
(In reply to shuo.wang from comment #3)
> Update the bug as a high priority since esconform should all pass.

Stop messing with bug priorities.
Comment 5 Matt Turner 2015-04-08 00:41:20 UTC
(In reply to shuo.wang from comment #1)
> Created attachment 114824 [details] [review] [review]
> Patch for mesa which is used to fix this issue

Please send this to the mesa-dev mailing list for review.
Comment 6 Tapani Pälli 2015-04-08 14:40:53 UTC
please see discussion in bug #87452
Comment 7 shuo.wang 2015-04-10 00:55:25 UTC
(In reply to Tapani Pälli from comment #6)
> please see discussion in bug #87452


Great! Thank you Tapani, agree with you and Chad, I will mark this bug is duplicate with bug #87452
Comment 8 shuo.wang 2015-04-10 00:55:50 UTC

*** This bug has been marked as a duplicate of bug 87452 ***
Comment 9 Gordon Jin 2015-04-14 06:16:43 UTC
Is this the same as bug#80248?
Comment 10 shuo.wang 2015-04-14 07:16:24 UTC
Yes, it seems they are the same bug.
Checked with Hua, we have already built mesa as Matt and Ian's comment "Mesa needs to be built with --with-egl-platforms= with drm. E.g., --with-egl-platforms=x11,drm --enable-gbm"
Comment 11 shuo.wang 2015-04-15 02:44:00 UTC

*** This bug has been marked as a duplicate of bug 80248 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.