The dEQP-GLES31.functional.texture.gather.basic.cube.* test cases are broken.
Setting the wrap modes to BRW_TEXCOORDMODE_CUBE appears to fix all of them.
The test use GL_NEAREST, so we override the wrap modes to CLAMP. However, textureGather forces GL_LINEAR filtering (regardless of what's specified), so CUBE may actually be appropriate.
If we do need to re-specify wrap modes based on the message type, this means having to double-emit surface states again...one for normal messages, and one for gather4. We have code for this, we'd just have to apply it in more cases.
I was wrong - we'd need to emit multiple SAMPLER_STATEs, not SURFACE_STATEs.
Is this the same as bug 94127 which I filed a while back?
Yep, thanks - I knew you filed one, but I didn't manage to dig it up. We'll add yours to the tracker and close this one as a duplicate.
*** This bug has been marked as a duplicate of bug 94127 ***