Bug 97034 - test-tpl-log-walker.c:172:1: error: conflicting types for ‘rewind’
Summary: test-tpl-log-walker.c:172:1: error: conflicting types for ‘rewind’
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
: 96985 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-21 23:21 UTC by Michael Catanzaro
Modified: 2016-07-22 14:04 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix build (4.32 KB, patch)
2016-07-21 23:24 UTC, Michael Catanzaro 		Details | Splinter Review
View All

Description Michael Catanzaro 2016-07-21 23:21:56 UTC 
I guess something is including stdio.h somewhere it previously wasn't, because telepathy-logger doesn't build in GNOME JHBuild on Fedora 24:

test-tpl-log-walker.c:172:1: error: conflicting types for ‘rewind’
 rewind (WalkerTestCaseFixture *fixture,
 ^~~~~~
In file included from /home/mcatanzaro/src/jhbuild/install/include/glib-2.0/glib/gmessages.h:33:0,
                 from /home/mcatanzaro/src/jhbuild/install/include/glib-2.0/glib.h:62,
                 from /home/mcatanzaro/src/jhbuild/install/include/glib-2.0/gobject/gbinding.h:28,
                 from /home/mcatanzaro/src/jhbuild/install/include/glib-2.0/glib-object.h:23,
                 from ../../tests/lib/simple-account.h:14,
                 from test-tpl-log-walker.c:5:
/usr/include/stdio.h:759:13: note: previous declaration of ‘rewind’ was here
 extern void rewind (FILE *__stream);
             ^~~~~~

Probably should just rename that function and be done with it.
Comment 1 Michael Catanzaro 2016-07-21 23:24:31 UTC 
Created attachment 125248 [details] [review]
Fix build
Comment 2 George Kiagiadakis 2016-07-22 04:37:21 UTC 

*** This bug has been marked as a duplicate of bug 96985 ***
Comment 3 Debarshi Ray 2016-07-22 14:03:01 UTC 
Comment on attachment 125248 [details] [review]
Fix build

Review of attachment 125248 [details] [review]:
-----------------------------------------------------------------

Pushed after adding the bug URL. Thanks, Michael.
Comment 4 Debarshi Ray 2016-07-22 14:04:26 UTC 
*** Bug 96985 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.