| Summary: | stop Gabble using long-deprecated things | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | gabble | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | jonny.lamb, xclaesse |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 31668 | ||
| Attachments: |
1/4] Stop using deprecated debug-ansi.h
2/4] Use TP_ERROR instead of deprecated TP_ERRORS 3/4] Use non-deprecated TpIntset APIs 4/4] Set G_MESSAGES_DEBUG during testing |
||
|
Description
Simon McVittie
2012-05-07 10:56:28 UTC
Created attachment 61162 [details] [review] 1/4] Stop using deprecated debug-ansi.h Created attachment 61163 [details] [review] 2/4] Use TP_ERROR instead of deprecated TP_ERRORS Created attachment 61164 [details] [review] 3/4] Use non-deprecated TpIntset APIs Created attachment 61165 [details] [review] 4/4] Set G_MESSAGES_DEBUG during testing With recent GLib, we don't see debug messages otherwise. --- Build and tests pass against telepathy-glib master, except that I see Bug #49595 (but I see that on master too, so, whatever). If we apply this patch, we can at least get logs more easily. Looks all good, +1. About the G_MESSAGES_DEBUG patch, does others CMs does that already? probably same patch is needed there too... (In reply to comment #5) > Looks all good, +1. Thanks, fixed in git for 0.17.0. > About the G_MESSAGES_DEBUG patch, does others CMs does that already? probably > same patch is needed there too... Yeah, all the CMs (+ MC) will need it. Applied to MC, Salut, Haze. I don't have a build environment for Rakia and Idle right now, but if the tests don't obviously fail catastrophically, I'll apply the same things there. Are patches applied, can we close this bug? (In reply to comment #7) > Are patches applied, can we close this bug? Yes, for 0.17.0. (In reply to comment #6) > I don't have a build environment for Rakia and Idle right now, but if the tests > don't obviously fail catastrophically, I'll apply the same things there. Rakia 0.7.4 and Idle 0.1.12. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.