Bug 49596 - stop Gabble using long-deprecated things
Summary: stop Gabble using long-deprecated things
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: tp-glib-1.0
  Show dependency tree / graph
 
Reported: 2012-05-07 10:56 UTC by Simon McVittie
Modified: 2012-05-30 05:09 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
1/4] Stop using deprecated debug-ansi.h (1.85 KB, patch)
2012-05-07 10:56 UTC, Simon McVittie 		Details | Splinter Review
2/4] Use TP_ERROR instead of deprecated TP_ERRORS (107.36 KB, patch)
2012-05-07 10:57 UTC, Simon McVittie 		Details | Splinter Review
3/4] Use non-deprecated TpIntset APIs (19.93 KB, patch)
2012-05-07 10:57 UTC, Simon McVittie 		Details | Splinter Review
4/4] Set G_MESSAGES_DEBUG during testing (823 bytes, patch)
2012-05-07 10:58 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2012-05-07 10:56:28 UTC 
As for Bug #49593 and Bug #49594, Gabble should keep up. This is a prerequisite for porting to 'next', too.
Comment 1 Simon McVittie 2012-05-07 10:56:55 UTC 
Created attachment 61162 [details] [review]
1/4] Stop using deprecated debug-ansi.h
Comment 2 Simon McVittie 2012-05-07 10:57:08 UTC 
Created attachment 61163 [details] [review]
2/4] Use TP_ERROR instead of deprecated TP_ERRORS
Comment 3 Simon McVittie 2012-05-07 10:57:20 UTC 
Created attachment 61164 [details] [review]
3/4] Use non-deprecated TpIntset APIs
Comment 4 Simon McVittie 2012-05-07 10:58:47 UTC 
Created attachment 61165 [details] [review]
4/4] Set G_MESSAGES_DEBUG during testing

With recent GLib, we don't see debug messages otherwise.

---

Build and tests pass against telepathy-glib master, except that I see Bug #49595 (but I see that on master too, so, whatever). If we apply this patch, we can at least get logs more easily.
Comment 5 Xavier Claessens 2012-05-07 11:09:47 UTC 
Looks all good, +1.

About the G_MESSAGES_DEBUG patch, does others CMs does that already? probably same patch is needed there too...
Comment 6 Simon McVittie 2012-05-07 11:33:06 UTC 
(In reply to comment #5)
> Looks all good, +1.

Thanks, fixed in git for 0.17.0.

> About the G_MESSAGES_DEBUG patch, does others CMs does that already? probably
> same patch is needed there too...

Yeah, all the CMs (+ MC) will need it. Applied to MC, Salut, Haze.

I don't have a build environment for Rakia and Idle right now, but if the tests don't obviously fail catastrophically, I'll apply the same things there.
Comment 7 Xavier Claessens 2012-05-30 01:55:52 UTC 
Are patches applied, can we close this bug?
Comment 8 Simon McVittie 2012-05-30 05:09:22 UTC 
(In reply to comment #7)
> Are patches applied, can we close this bug?

Yes, for 0.17.0.

(In reply to comment #6)
> I don't have a build environment for Rakia and Idle right now, but if the tests
> don't obviously fail catastrophically, I'll apply the same things there.

Rakia 0.7.4 and Idle 0.1.12.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.