Created attachment 106346 [details]
Bad icons in Steam Big Picture mode
During testing of SteamOS, we would sometimes see incorrect icon colors in Steam Big Picture mode.
I was able to capture the behavior in a trace. I've attached a screenshot of the issue. I've got a 137MB apitrace file of it, if anyone is interested.
We bisected it to 61e264f4, which changes the internal format of textures, routing glTexImage2D to new code paths.
We debugged it to PBO offsets that are not naturally pixel aligned, which causes the BLT path to drop bits.
I've got a fix to send to the list, and will also submit a piglit test that shows the issue.
I'll update this bug as I send out the patches and tests.
Test sent to piglit list:
Patch sent to mesa-dev:
Just pushed to master. I don't think Neil realized that Cody didn't have commit access... and then everyone forgot about it.
Author: Cody Northrop <email@example.com>
Date: Mon Sep 15 16:14:20 2014 -0600
i965: Require pixel alignment for GPU copy blit
The blitter will start at a pixel's natural alignment. For PBOs, if the
provided offset if not aligned, bits will get dropped.
This change adds offset alignment check for src and dst, kicking back if
the requirements are not met.
The change is based on following verbiage from BSPEC:
Color pixel sizes supported are 8, 16, and 32 bits per pixel (bpp).
All pixels are naturally aligned.
Found in the following locations:
page 35 of intel-gfx-prm-osrc-hsw-blitter.pdf
page 29 of ivb_ihd_os_vol1_part4.pdf
page 29 of snb_ihd_os_vol1_part5.pdf
This behavior was observed with Steam Big Picture rendering incorrect
icon colors. The fix has been tested on Ubuntu and SteamOS on Haswell.
Signed-off-by: Cody Northrop <firstname.lastname@example.org>
Reviewed-by: Neil Roberts <email@example.com>
*** Bug 89913 has been marked as a duplicate of this bug. ***